Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of cursor in margin area? #635

Closed
bluenlive opened this issue Mar 16, 2023 · 12 comments
Closed

Size of cursor in margin area? #635

bluenlive opened this issue Mar 16, 2023 · 12 comments
Labels
Milestone

Comments

@bluenlive
Copy link

Hello.

I am using a large sized mouse cursor.
However, in notepad2-mod, when I move the cursor to the margin area, the size of the cursor is reduced to the default size.
Is it possible to modify this to keep the size of the mouse cursor?

@zufuliu zufuliu added upstream scintilla Changes depends on upstream Scintilla 🐛bug Hi-DPI labels Mar 16, 2023
@zufuliu
Copy link
Owner

zufuliu commented Mar 16, 2023

@zufuliu
Copy link
Owner

zufuliu commented Mar 16, 2023

@zufuliu zufuliu added the Hi-DPI label Mar 16, 2023
@zufuliu
Copy link
Owner

zufuliu commented Mar 16, 2023

mouse pointer size is respected when dragging items on "Schemes -> Favorite Schemes" dialog with Copy.cur, we may need a RevereArrow.cur?

@bluenlive
Copy link
Author

bluenlive commented Mar 16, 2023

mouse pointer size is respected when dragging items on "Schemes -> Favorite Schemes" dialog with Copy.cur, we may need a RevereArrow.cur?

I'm not sure.
But for me, I usually use a large blue mouse cursor.
Therefore, it feels more natural to flip the cursor rather than use ReversrArrow.cur.

Thanks.

@zufuliu
Copy link
Owner

zufuliu commented Mar 17, 2023

more natural to flip the cursor

Need to find API to retrieve actual cursor size (see https://sourceforge.net/p/scintilla/bugs/2321/).

@bluenlive
Copy link
Author

@zufuliu
We can get actual cursor size from registry.

HKEY_CURRENT_USER\SOFTWARE\Microsoft\Accessibility
CursorSize
or
HKEY_CURRENT_USER\Control Panel\Cursors
CursorBaseSize

But, I couldn't find API.

https://learn.microsoft.com/en-us/answers/questions/815036/windows-cursor-size

@zufuliu zufuliu added this to the v4.24.05 milestone Apr 14, 2024
@zufuliu
Copy link
Owner

zufuliu commented Apr 14, 2024

Added a draft implementation using HKEY_CURRENT_USER\Control Panel\Cursors\CursorBaseSize in 244c226.

@bluenlive
Copy link
Author

@zufuliu
Thanks for your work.
I checked it out right away.

The code seems to be working as intended.
However, the cursor we see on the screen is jagged because the original that the program is zooming in on is a 32x32 cursor...

@bluenlive
Copy link
Author

I think I'd better close this issue here.
Thank you for your work again.

@zufuliu
Copy link
Owner

zufuliu commented Apr 14, 2024

Here may be further changes based on https://sourceforge.net/p/scintilla/bugs/2321/.

@zufuliu
Copy link
Owner

zufuliu commented Apr 19, 2024

Full fixed by 8671ed5, may still have minor code changes after the change been backported into Scintilla.

@zufuliu
Copy link
Owner

zufuliu commented May 16, 2024

Scintilla is going to draw the reverse arrow cursor (based on C:\Windows\Cursors\arrow.svg) with code similar to 185311d and 1291ba3, the drawing code can be enabled by set line 2874 to 0:

https://github.com/zufuliu/notepad2/blob/a4c927b0315dc45868193173e7505827f53a2fa1/scintilla/win32/PlatWin.cxx#L2874

@zufuliu zufuliu closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants