Skip to content

Commit

Permalink
pypi: Include py.typed in MANIFEST.in.
Browse files Browse the repository at this point in the history
According to the `setuptools` docs, once `include_package_data=True`
is passed to `setup()`, it will only include package data specified
in `MANIFEST.in`, and will ignore the `package_data` argument passed
to `setup()`. Therefore, `py.typed` was not included in our latest
PyPI release 0.8.1.

Since we specify all of our package data in the `MANIFEST.in` file
already, it makes more sense to include mention `py.typed` there so
that it is included in the expected fashion.

See pypa/setuptools#1461 for background.

Fixes #732.
  • Loading branch information
eeshangarg authored and timabbott committed Oct 27, 2021
1 parent 58e51c7 commit bdc4901
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions zulip/MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
recursive-include integrations *
include README.md
include zulip/examples/*
include zulip/py.typed
1 change: 0 additions & 1 deletion zulip/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def recur_expand(target_root: Any, dir: Any) -> Generator[Tuple[str, List[str]],
"zulip-api=zulip.cli:cli",
],
},
package_data={"zulip": ["py.typed"]},
) # type: Dict[str, Any]

setuptools_info = dict(
Expand Down

0 comments on commit bdc4901

Please sign in to comment.