Allow non-Zulip.com installs to login via Google Auth #70

kunall17 · 2016-06-21T21:01:47Z

Fixed #64 ! :)
Used Open-ID Auth library to create the Auth System!

Requires two Client ID's in the settings.py here
'GOOGLE_CLIENT_ID'and 'GOOGLE_OAUTH2_CLIENT_ID'and ofcourse GoogleMobileOauth2Backend to be enabled in the Authentication Backends!

Demo:

smarx · 2016-06-21T21:01:49Z

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

niftynei · 2016-06-22T20:03:00Z

app/build.gradle

@@ -5,7 +5,7 @@ android {
    buildToolsVersion "23.0.2"
    defaultConfig {
        applicationId "com.zulip.android"
-        minSdkVersion 13
+        minSdkVersion 16


This is a change that potentially has a pretty big impact on the Zulip install base. What's the reason for upping this to 16?

When I added AppAuth dependency I got this error!

Error:Execution failed for task ':app:processDebugManifest'. > Manifest merger failed : uses-sdk:minSdkVersion 13 cannot be smaller than version 16 declared in library [net.openid:appauth:0.2.0] Suggestion: use tools:overrideLibrary="net.openid.appauth" to force usage

AppAuth asks for 16, so I bumped it up. Didn't wanted to force usage.!

Cool. For now, let's assume it's ok :)

niftynei · 2016-06-22T21:55:09Z

This looks really good overall @kunall17!! great job!!

A few things:
= If there's any errors in the server we're not doing a very good job of displaying them for the user. For example, if the server you're attempting to log into doesn't have a Google ID set up, we should remove the Google Login button in the UI.

= If you go to "Login with Google" and then click the X button to go back to the login screen, the spinner is still showing.

kunall17 · 2016-06-23T13:07:18Z

@niftynei Updated the Code! :)

niftynei · 2016-06-23T19:23:13Z

Cool, thanks Kunal.

I'm having some trouble getting the login to complete correctly. I've got the Oauth Keys set up and can successfully complete the Oauth portion but when it navigates back to the app it seems to both log me out and successfully complete. As a result, I end up on a new LogInActivity (hitting the back button takes me to the first LogInActivity), but I can't successfully get to the messages view. I can see the app making all the right API calls to my dev server, but also making a call to log me out. Do you also have this behavior?

There's also these errors in the logs:


06-23 15:00:56.867 5090-5090/com.zulip.android.dev E/ActivityThread: Activity com.zulip.android.activities.LoginActivity has leaked ServiceConnection net.openid.appauth.BrowserHandler$1@f2300ab that was originally bound here
                                                                     android.app.ServiceConnectionLeaked: Activity com.zulip.android.activities.LoginActivity has leaked ServiceConnection net.openid.appauth.BrowserHandler$1@f2300ab that was originally bound here
                                                                         at android.app.LoadedApk$ServiceDispatcher.<init>(LoadedApk.java:1092)
                                                                         at android.app.LoadedApk.getServiceDispatcher(LoadedApk.java:986)
                                                                         at android.app.ContextImpl.bindServiceCommon(ContextImpl.java:1303)
                                                                         at android.app.ContextImpl.bindService(ContextImpl.java:1286)
                                                                         at android.content.ContextWrapper.bindService(ContextWrapper.java:604)
                                                                         at android.support.customtabs.CustomTabsClient.bindCustomTabsService(CustomTabsClient.java:60)
                                                                         at net.openid.appauth.BrowserHandler.bindCustomTabsService(BrowserHandler.java:86)
                                                                         at net.openid.appauth.BrowserHandler.<init>(BrowserHandler.java:61)
                                                                         at net.openid.appauth.AuthorizationService.<init>(AuthorizationService.java:98)
                                                                         at com.zulip.android.activities.LoginActivity.setupSignIn(LoginActivity.java:237)
                                                                         at com.zulip.android.activities.LoginActivity.access$000(LoginActivity.java:40)
                                                                         at com.zulip.android.activities.LoginActivity$1.onTaskComplete(LoginActivity.java:147)
                                                                         at com.zulip.android.networking.ZulipAsyncPushTask.onPostExecute(ZulipAsyncPushTask.java:145)
                                                                         at com.zulip.android.networking.ZulipAsyncPushTask.onPostExecute(ZulipAsyncPushTask.java:24)
                                                                         at android.os.AsyncTask.finish(AsyncTask.java:651)
                                                                         at android.os.AsyncTask.-wrap1(AsyncTask.java)
                                                                         at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:668)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                         at android.os.Looper.loop(Looper.java:148)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:5422)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

06-23 15:16:37.083 8584-8584/com.zulip.android.dev I/GOOGLE_SIGN: Handled Authorization Response {"scope":"profile email","lastAuthorizationResponse":{"request":{"configuration":{"authorizationEndpoint":"https:\/\/accounts.google.com\/o\/oauth2\/v2\/auth","tokenEndpoint":"https:\/\/www.googleapis.com\/oauth2\/v4\/token"},"clientId":"740118079718-nc6dcpssofjdg0i84r89gita43o9jbuc.apps.googleusercontent.com","responseType":"code","redirectUri":"com.zulip.android:\/oauth2callback","scope":"profile email","state":"EYil7D70UUUvg5fs3nlHpA","codeVerifier":"X3phVzGiDxoVxLG-AEVYEalH-q6sPF4yrxDdDqsUwJlGzE310UFlV85g2d9SW1Ahkk-MrDjEEiSp-sOVD407rA","codeVerifierChallenge":"a0R4MK66ycPpya2qh_2bKCYJ1FRtVG9clcanfUwYk0E","codeVerifierChallengeMethod":"S256","additionalParameters":{}},"state":"EYil7D70UUUvg5fs3nlHpA","code":"4\/aJBrq-ZPzF3d6TDSO4zn9svZnUWOFpY4zNcBso2phKE","additional_parameters":{}}} 
06-23 15:16:37.329 8584-8584/com.zulip.android.dev W/GOOGLE_SIGN: Token Exchange failed
                                                                  AuthorizationException: {"type":0,"code":3,"errorDescription":"Network error"}
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:244)
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:206)
                                                                      at android.os.AsyncTask$2.call(AsyncTask.java:295)
                                                                      at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                      at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
                                                                      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
                                                                      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
                                                                      at java.lang.Thread.run(Thread.java:818)
                                                                   Caused by: java.io.FileNotFoundException: https://www.googleapis.com/oauth2/v4/token
                                                                      at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:238)
                                                                      at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
                                                                      at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java)
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:239)
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:206) 
                                                                      at android.os.AsyncTask$2.call(AsyncTask.java:295) 
                                                                      at java.util.concurrent.FutureTask.run(FutureTask.java:237) 
                                                                      at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234) 
                                                                      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) 
                                                                      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) 
                                                                      at java.lang.Thread.run(Thread.java:818)

kunall17 · 2016-06-24T05:59:19Z

If I use my keys for the Web client I too receive the same error!
I have this setup
'GOOGLE_CLIENT_ID' as the Android client
'GOOGLE_OAUTH2_CLIENT_ID' as the web client in my server!

06-24 11:16:58.860 2810-2810/com.zulip.android.dev W/GOOGLE_SIGN: Token Exchange failed
                                                                  AuthorizationException: {"type":0,"code":3,"errorDescription":"Network error"}
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:244)
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:206)
                                                                      at android.os.AsyncTask$2.call(AsyncTask.java:292)
                                                                      at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                      at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
                                                                      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
                                                                      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
                                                                      at java.lang.Thread.run(Thread.java:818)
                                                                   Caused by: java.io.FileNotFoundException: https://www.googleapis.com/oauth2/v4/token
                                                                      at com.android.okhttp.internal.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:206)
                                                                      at com.android.okhttp.internal.http.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
                                                                      at com.android.okhttp.internal.http.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25)
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:239)
                                                                      at net.openid.appauth.AuthorizationService$TokenRequestTask.doInBackground(AuthorizationService.java:206) 
                                                                      at android.os.AsyncTask$2.call(AsyncTask.java:292) 
                                                                      at java.util.concurrent.FutureTask.run(FutureTask.java:237) 
                                                                      at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231) 
                                                                      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) 
                                                                      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) 
                                                                      at java.lang.Thread.run(Thread.java:818)

kunall17 · 2016-06-24T18:12:23Z

@niftynei for the If you go to "Login with Google" and then click the X button to go back to the login screen, the spinner is still showing.

To set a CustomTabsCallback (callback which gets the events in chrome custom tabs) is currently not available in the 0.2.0 version of openId AppAuth library, I have made changes in the library for this callback and posted a PR in their repository but I'm not sure when this will be merged and a new version of the library will be released , they had talks about new version coming up soon last month.
Currently I have dismissed the dialog when the Google client ID is fetched from the server as after that the custom chrome tabs show up for, which is not a great solution.

Will it be right to include their library as a module and compile with the fix in our gradle?

kunall17 · 2016-07-10T04:18:18Z

@niftynei updated the branch! :)

niftynei · 2016-07-19T00:40:21Z

@kunall17 were you able to successfully use this to log in to a server other than your dev server? I believe http://zulip.tabbott.net is set up to do this now.

niftynei · 2016-07-19T22:03:59Z

@kunall17 I haven't been able to get this branch to build. I'm getting org.apache.http.client does not exist errors on AsyncGoogleIDFetch.

kunall17 · 2016-07-19T22:38:53Z

Damn, sorry the silly rebase conflicts.
Btw we should really think to implement a CI to do these things for us?

niftynei · 2016-07-19T22:43:18Z

Yeah, that's a good idea. @timabbott sent me one a few weeks ago, I'll look into setting it up.

niftynei · 2016-07-19T23:40:35Z

@kunall17 I can't for the life of me get this working. I'm sending you an email to get some help debugging my setup. :(

niftynei · 2016-07-21T20:36:54Z

@kunall17 if you could add the docs for how to set up a web server to use this that you're writing up to this PR, I'll go ahead and get it merged in. We can retro-actively fix any other errors that come up.

kunall17 · 2016-07-21T20:38:36Z

@niftynei I was just waiting for zulip.tabbott.net to get this thing working then I would go edit the docs!

niftynei · 2016-09-09T14:47:14Z

this has been fixed by using the same GOOGLE_CLIENT_ID for all installs.

kunall17 force-pushed the patch-7-googlesignin branch from 7d659db to c20dafe Compare June 22, 2016 04:57

niftynei reviewed Jun 22, 2016
View reviewed changes

kunall17 force-pushed the patch-7-googlesignin branch from c20dafe to df38b32 Compare June 23, 2016 13:05

niftynei mentioned this pull request Jun 23, 2016

Bugfix api calls and gcm key #68

Closed

kunall17 force-pushed the patch-7-googlesignin branch from df38b32 to ce9b571 Compare July 10, 2016 04:16

kunall17 force-pushed the patch-7-googlesignin branch from ce9b571 to 43f0bb3 Compare July 19, 2016 19:14

kunall17 force-pushed the patch-7-googlesignin branch from 43f0bb3 to 6e4ed65 Compare July 19, 2016 22:37

kunall17 added 9 commits July 20, 2016 04:16

Removed Existing Google AUTH Code

63c4bcd

Added openId Auth Dependencies

192b9c2

Stop hiding sign in button on checkBox

8b2603e

Fetch Google clientId from server

a71a114

Setup Auth Service

6edc913

Recieve Intent

0fa20cc

Extract token from google

a0ad9a0

Login Using the recieved Token

b38e211

Hide GoogleSignIn Button if google client not configured on that server

7afcf6d

kunall17 force-pushed the patch-7-googlesignin branch from 6e4ed65 to 7afcf6d Compare July 19, 2016 22:51

niftynei closed this Sep 9, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow non-Zulip.com installs to login via Google Auth #70

Allow non-Zulip.com installs to login via Google Auth #70

kunall17 commented Jun 21, 2016

smarx commented Jun 21, 2016

niftynei Jun 22, 2016

kunall17 Jun 22, 2016 •

edited

Loading

niftynei Jun 22, 2016

niftynei commented Jun 22, 2016

kunall17 commented Jun 23, 2016

niftynei commented Jun 23, 2016

kunall17 commented Jun 24, 2016

kunall17 commented Jun 24, 2016 •

edited

Loading

kunall17 commented Jul 10, 2016

niftynei commented Jul 19, 2016

niftynei commented Jul 19, 2016

kunall17 commented Jul 19, 2016

niftynei commented Jul 19, 2016

niftynei commented Jul 19, 2016

niftynei commented Jul 21, 2016

kunall17 commented Jul 21, 2016

niftynei commented Sep 9, 2016

Allow non-Zulip.com installs to login via Google Auth #70

Allow non-Zulip.com installs to login via Google Auth #70

Conversation

kunall17 commented Jun 21, 2016

smarx commented Jun 21, 2016

niftynei Jun 22, 2016

Choose a reason for hiding this comment

kunall17 Jun 22, 2016 • edited Loading

Choose a reason for hiding this comment

niftynei Jun 22, 2016

Choose a reason for hiding this comment

niftynei commented Jun 22, 2016

kunall17 commented Jun 23, 2016

niftynei commented Jun 23, 2016

kunall17 commented Jun 24, 2016

kunall17 commented Jun 24, 2016 • edited Loading

kunall17 commented Jul 10, 2016

niftynei commented Jul 19, 2016

niftynei commented Jul 19, 2016

kunall17 commented Jul 19, 2016

niftynei commented Jul 19, 2016

niftynei commented Jul 19, 2016

niftynei commented Jul 21, 2016

kunall17 commented Jul 21, 2016

niftynei commented Sep 9, 2016

kunall17 Jun 22, 2016 •

edited

Loading

kunall17 commented Jun 24, 2016 •

edited

Loading