Nit fixes to older PR code.

zulip · Jan 7, 2021 · 5544153 · 5544153
1 parent d77eaed
commit 5544153
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/app/renderer/js/main.ts b/app/renderer/js/main.ts
@@ -89,7 +89,7 @@ class ServerManagerView {
 	$sidebar: Element;
 	$fullscreenPopup: Element;
 	$fullscreenEscapeKey: string;
-	$sortableList: any;
+	$sortableList: Sortable;
 	loading: Set<string>;
 	activeTabIndex: number;
 	servers: DomainUtil.ServerConf[];
@@ -244,7 +244,6 @@ class ServerManagerView {
 		tabElements.forEach((element, index) => {
 			const oldIndex = Number(element.getAttribute('data-tab-id')) % this.servers.length;
 			newServers.push(this.servers[oldIndex]);
-			// TODO: Change this to read data from in-memory store or DomainUtil.
 			(element as HTMLElement).dataset.tabId = index.toString();
 		});
 		this.servers = newServers;

diff --git a/package.json b/package.json
@@ -161,7 +161,8 @@
     "i18n": "^0.13.2",
     "iso-639-1": "^2.1.4",
     "node-json-db": "^1.1.0",
-    "semver": "^7.3.4"
+    "semver": "^7.3.4",
+    "sortablejs": "^1.10.2"
   },
   "devDependencies": {
     "@types/adm-zip": "^0.4.33",

diff --git a/typings.d.ts b/typings.d.ts
@@ -43,10 +43,3 @@ interface ElectronBridge {
 	set_send_notification_reply_message_supported: (value: boolean) => void;
 	decrypt_clipboard: (version: number) => ClipboardDecrypter;
 }
-
-interface Domain {
-	icon: string;
-	url: string;
-	alias: string;
-	ignoreCerts: boolean;
-}