Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download notifications don't show up in latest version #1333

Closed
FeldrinH opened this issue Sep 27, 2023 · 1 comment · Fixed by #1334
Closed

Download notifications don't show up in latest version #1333

FeldrinH opened this issue Sep 27, 2023 · 1 comment · Fixed by #1334

Comments

@FeldrinH
Copy link

FeldrinH commented Sep 27, 2023

Describe the bug

With Zulip Desktop v5.10.0 when I clicked on a file it would download it and then show a notification that the file had been downloaded. Since updating to v5.10.2 this morning that no longer works. When I click on a file to download it it is shows up in the Downloads folder, but no notifiaction is shown and no other indication is given that the download had started or completed.

To Reproduce

Send/find a message with a file and click on the link once to download it. The file will appear in your Donwloads folder but no notification will show up indicating that anything happened.

Expected behavior

File downloads should show some indications that they were started/completed, just like they did in v5.10.0.

Screenshots

The file download notification that used to appear but no longer does:
image

Desktop (please complete the following information):

  • Operating System: Windows 10 (10.0.19045)
  • Zulip Desktop Version: 5.10.2 (bug did not exist in 5.10.0)
@FeldrinH FeldrinH changed the title Download notifications don't work in latest version Download notifications don't show up in latest version Sep 27, 2023
@andersk
Copy link
Member

andersk commented Sep 27, 2023

Thanks for the report. I tracked this down to an upstream Electron change that broke the third-party gatemaker library, and opened javan/gatemaker#4. I’ll get a fixed release out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants