Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for undefined event.sender in Electron ≥ 25 #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andersk
Copy link

@andersk andersk commented Sep 27, 2023

In Electron ≥ 25, event.sender is now undefined for events that are not IPC events. This breaks gatemaker with

TypeError: Cannot read properties of undefined (reading 'getSavePath')

This was apparently an intended change upstream; see

Instead use this, which has the same value in Electron < 25 and remains usable in Electron ≥ 25.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'getSavePath') in Electron ≥ 25
1 participant