Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transifex: Setup Transifex for better translation process. #957

Merged
merged 4 commits into from
May 20, 2020
Merged

transifex: Setup Transifex for better translation process. #957

merged 4 commits into from
May 20, 2020

Conversation

manavmehta
Copy link
Collaborator

@manavmehta manavmehta commented May 12, 2020 •
edited
Loading

What's this PR do?

  1. add .tx/config to configure communication with Transifex CLI
  2. add how-to-doc for translating zulip-desktop
  3. add tx-pull executable script for pulling translations from Transifex
  4. update supported-locales.json
  5. remove now-inessential scripts and translations

and other necessary changes

You have tested this PR on:

  • macOS
  • Ubuntu 20.04

@zulipbot zulipbot added size: L and removed size: XL labels May 13, 2020
@timabbott
Copy link
Sponsor Member

The slug in .tx/config should be: zulip.desktopjson

Otherwise, the Transifex integration wfm.

manavmehta and others added 2 commits May 13, 2020 13:59
@manavmehta @timabbott
transifex: Setup Transifex - initial commit
b9c0bf1 
1. add .tx/config to configure communication with transifex CLI
2. add how-to-doc for translating zulip-desktop
3. add tx-pull executable script for pulling translations from transifex
@timabbott
Update translation data from Transifex.
20d91ea
@zulipbot zulipbot added size: XL and removed size: L labels May 13, 2020
@timabbott
Copy link
Sponsor Member

I fixed that slug, ran tools/tx-pull, and pushed back here following that change.

@manavmehta
Copy link
Collaborator Author

@akashnimare FYI.
May we look into removing the inessential modules here?

@akashnimare
Copy link
Member

@manavmehta yes, please remove that since we won't be using that module.

@manavmehta
revert inessential parts of 8e04920
82f6c31 
As now we won't be needing the google-translate-api, we need to remove the redundant dependency,
and the locale-helper directory which may override our Transifex translations

We will preserve the translated key-value json modules and the executable scripts from the commit
@manavmehta
Copy link
Collaborator Author

manavmehta commented May 15, 2020 •
edited
Loading

@akashnimare Removed the locale-helper from 8e04920 which is now not needed.
I've updated the supported-locales module :)
I've used native scripts for language names as we use them on the webapp. If you feel we could go for English names only.
cc: @timabbott

@manavmehta
Update supported-locales.json and other necessary changes
1877323 
1. Update supported-locales.json to accommodate new languages added (with native scripts)
2. Remove en-US as it is not on our Transifex repository
3. Set default dropdown language as en, as a result of *2.*
@akashnimare
Copy link
Member

tx-pull works fine. @andersk can you give a quick review so that we can merge it?

@akashnimare
Copy link
Member

This is GTM after we pull a few strings which are there on Trasifex.

@akashnimare akashnimare changed the title [WIP] transifex: Setup Transifex for better translation process transifex: Setup Transifex for better translation process May 19, 2020
@akashnimare
Copy link
Member

Merging. Will update the strings on tx.

@akashnimare akashnimare changed the title transifex: Setup Transifex for better translation process transifex: Setup Transifex for better translation process. May 20, 2020
@akashnimare akashnimare merged commit a5ceffc into zulip:master May 20, 2020
@manavmehta manavmehta deleted the transifex branch May 20, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manavmehta @timabbott @akashnimare @zulipbot