spellchecker: Use Electron 8 built-in spellchecker. #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just had a quick run - this works well. |
abhigyank
reviewed
May 24, 2020
manavmehta
commented
May 30, 2020
andersk
reviewed
May 31, 2020
manavmehta
commented
Jun 6, 2020
There was a problem hiding this comment.
The code would've been much shorter if the package ISO-639-1 had corresponding names for some of the locale codes from electron.
abhigyank
reviewed
Jun 6, 2020
abhigyank
reviewed
Jun 6, 2020
manavmehta
force-pushed
the
contextmenu
branch
2 times, most recently
from
c1b20e4
to
f342fa0
Compare
|
Functionality is working for me. Almost mergable I suppose. |
manavmehta
changed the title
andersk
reviewed
Jun 7, 2020
andersk
reviewed
Jun 7, 2020
manavmehta
force-pushed
the
contextmenu
branch
2 times, most recently
from
fee38c2
to
8e15134
Compare
andersk
reviewed
Jun 8, 2020
manavmehta
force-pushed
the
contextmenu
branch
2 times, most recently
from
7b51920
to
9cbc332
Compare
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
* It performs the appropriate operations * Provides suggestions for misspellings caught by electron's built-in spellchecker * Will be maintained by the organisation * Tag-input in Setings -> General -> Functionality to select max 3 languages (stored on disk) * Pass the languages to spellchecker, after fetching from disk Fixes: zulip#504
* Better type annotations * Use DOM manipulation instead of HTML generation * Internationalize strings * Use .map and .filter to avoid quadratic loop * source tagify.css from node_modules * declare @yaireo/tagify * Proper internationalization
* Passing correct parameters including contextMenuParams * Typecasting event: Event
manavmehta
force-pushed
the
contextmenu
branch
3 times, most recently
from
462db7a
to
9a279e9
Compare
abhigyank
reviewed
Jun 18, 2020
* Bug fix: broken customCSS * Improvement: set default spellcheck lang * Improvement: ensure spellchecker is set for every session * Bug fix: json.parse() cannot parse empty array string when all the langs are deselected
akashnimare
changed the title
|
Merged. Thanks, everyone for working on this 🚀 |
|
This works well. There are a couple of minor things which we'll be adding as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
#928 takes away with it the context menu as so this PR implements a custom context menu
Inherits commit from #928 as it was needed
Screenshots?
You have tested this PR on:
Also fixes: #504