Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a login flow #11

Closed
gnprice opened this issue Feb 23, 2023 · 1 comment · Fixed by #39
Closed

Add a login flow #11

gnprice opened this issue Feb 23, 2023 · 1 comment · Fixed by #39
Labels
a-login

Comments

@gnprice
Copy link
Member

gnprice commented Feb 23, 2023

As explained in the README, this prototype currently requires baking in a set of account credentials at build time.

By using an appropriate test account, that works fine for development and even for distributing a build among a handful of people. But it'd get unwieldy for distributing a build to more people, especially now (after #9) that the app's functionality isn't all read-only.

So we should add the ability for the user to log in in a normal way, and should then remember the resulting credentials in the app's storage.
@gnprice gnprice mentioned this issue Feb 23, 2023
Closed
This was referenced Mar 3, 2023
Closed
Merged
This was referenced Mar 29, 2023
Merged
Closed
@gnprice gnprice changed the title Add a login flow, and store login credentials Add a login flow Mar 30, 2023
@gnprice
Copy link
Member Author

gnprice commented Mar 30, 2023

Splitting this issue in two: this one will track just the login flow itself, and I've added #34 for storing the resulting credentials on the device.

To get a reasonable user experience we'll need both. But the login flow is a nontrivial enough UI, and starting to do on-device storage is a large enough infrastructural task, that I think I'll want to merge the one without blocking on the other. So this is the issue we'll close on merging the login flow, and then #34 is an important followup.

This was referenced Mar 30, 2023
Closed
Closed
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Mar 31, 2023
@gnprice
login: Add a basic login flow
1ce5634 
There's plenty more to do to improve the UX of this, and I've
filed several follow-up issues.  Most critically, we'll need
to store the resulting credentials on the device, so you don't
have to repeat the login each time you start the app.

But this is enough that it becomes possible to log in at an
account of your choice, making the flow testable end to end.
In particular this makes a useful bootstrapping step toward
the task of storing data locally: with this, there's now some
useful data we could store.

Fixes: zulip#11
@gnprice gnprice mentioned this issue Mar 31, 2023
Merged
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Apr 4, 2023
@gnprice
login: Add a basic login flow
5a08128 
There's plenty more to do to improve the UX of this, and I've
filed several follow-up issues.  Most critically, we'll need
to store the resulting credentials on the device, so you don't
have to repeat the login each time you start the app.

But this is enough that it becomes possible to log in at an
account of your choice, making the flow testable end to end.
In particular this makes a useful bootstrapping step toward
the task of storing data locally: with this, there's now some
useful data we could store.

Fixes: zulip#11
@gnprice gnprice closed this as completed in c2748be Apr 4, 2023
@gnprice gnprice mentioned this issue Apr 13, 2023
Merged
@gnprice gnprice mentioned this issue Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-login
Projects
Flutter app
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

login: Add a basic login flow gnprice/zulip-flutter
1 participant
@gnprice