Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding/removing a reaction #125

Closed
gnprice opened this issue May 26, 2023 · 1 comment · Fixed by #410
Closed

Support adding/removing a reaction #125

gnprice opened this issue May 26, 2023 · 1 comment · Fixed by #410
Assignees
@chrisbobbe
Labels
a-api Implementing specific parts of the Zulip server API a-msglist The message-list screen, except what's label:a-content
Milestone
Alpha

Comments

@gnprice
Copy link
Member

gnprice commented May 26, 2023 •
edited
Loading

This will be a followup to:

This issue is for adding UI to support the user adding or removing a reaction of their own to a message.

For this issue, it's enough if the user can:

  • add a thumbs-up reaction;
  • remove a reaction they've already made; and
  • join in on an existing reaction other people have made.

For Beta 2 we'll want a further ability, which we'll leave as a followup issue:
@gnprice gnprice added m-alpha a-msglist The message-list screen, except what's label:a-content a-api Implementing specific parts of the Zulip server API labels May 26, 2023
@gnprice gnprice added this to the Alpha milestone May 27, 2023
@gnprice gnprice removed the m-alpha label May 27, 2023
@chrisbobbe chrisbobbe mentioned this issue Aug 15, 2023
Merged
@chrisbobbe
Copy link
Collaborator

add a thumbs-up reaction;

At first, this can just be an item in the message action sheet. Then later we can add the ability to add an arbitrary reaction.

@gnprice gnprice mentioned this issue Nov 18, 2023
Open
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 22, 2023
@chrisbobbe
msglist: Show message reactions!
abb7619 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

It leaves out one part of zulip#125, for now:
- joining in on an existing reaction other people have made

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we'll
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that's
worth being aware of.
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 22, 2023
@chrisbobbe
msglist: Show message reactions!
a6a0fee 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

It leaves out one part of zulip#125, for now:
- joining in on an existing reaction other people have made

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we'll
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that's
worth being aware of.
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 22, 2023
@chrisbobbe
msglist: Show message reactions!
ecce64c 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

It leaves out one part of zulip#125, for now:
- joining in on an existing reaction other people have made

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we'll
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that's
worth being aware of.
@gnprice gnprice mentioned this issue Nov 22, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 22, 2023
@chrisbobbe
msglist: Show message reactions!
001d8d0 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

It leaves out one part of zulip#125, for now:
- joining in on an existing reaction other people have made

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we'll
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that's
worth being aware of.

Fixes: zulip#121
Fixes-partly: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 22, 2023
@chrisbobbe
msglist: Support adding a thumbs-up reaction
a3a5f5a 
Fixes: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 27, 2023
@chrisbobbe
msglist: Show message reactions!
4c5abf1 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we'll
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that's
worth being aware of.

Fixes: zulip#121
Fixes-partly: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 27, 2023
@chrisbobbe
msglist: Support adding a thumbs-up reaction
00d42b4 
Fixes: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 30, 2023
@chrisbobbe
msglist: Show message reactions!
2a282f6 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we may
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that
probably has something to do with it.

Fixes: zulip#121
Fixes-partly: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 30, 2023
@chrisbobbe
msglist: Support adding a thumbs-up reaction
c84040a 
Fixes: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 30, 2023
@chrisbobbe
msglist: Show message reactions!
e7a7bef 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we may
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that
probably has something to do with it.

Fixes: zulip#121
Fixes-partly: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 30, 2023
@chrisbobbe
msglist: Support adding a thumbs-up reaction
a3d0070 
Fixes: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 1, 2023
@chrisbobbe
msglist: Show message reactions!
af03b20 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we may
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that
probably has something to do with it.

Fixes: zulip#121
Fixes-partly: zulip#125
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 1, 2023
@chrisbobbe
msglist: Support adding a thumbs-up reaction
b4b6648 
Fixes: zulip#125
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 1, 2023
@chrisbobbe @gnprice
msglist: Show message reactions!
6337a98 
And also support:
- removing a reaction you've already made, and
- joining in on existing reactions that other people have made.

As is our habit with the message list, this aims to be faithful to
the web app, as accessed today. That should be a good baseline to
make mobile-specific adjustments from. (In particular I think we may
want larger touch targets.)

Unlike the web app, we use a font instead of a sprite sheet to
render Unicode emoji. This means that we, unlike web, have to
account for text-layout algorithms, and things like font metrics. So
if Unicode emoji appear noticeably differently from web, that
probably has something to do with it.

Fixes: zulip#121
Fixes-partly: zulip#125
@gnprice gnprice closed this as completed in 8f43bc6 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-api Implementing specific parts of the Zulip server API a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
Alpha
2 participants
@gnprice @chrisbobbe