Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle moved messages (update_message events, 2/2) #150

Open
gnprice opened this issue Jun 2, 2023 · 1 comment
Open

Handle moved messages (update_message events, 2/2) #150

gnprice opened this issue Jun 2, 2023 · 1 comment
Assignees
@PIG208
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Milestone
Beta 3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented Jun 2, 2023

https://zulip.com/api/get-events#update_message

This issue is for the case where the messages were moved to a different stream or topic. (The case where a message's content changed is #118.)

In particular these should be handled in the MessageListView view-model, so that the message disappears from the view if it no longer belongs in that particular narrow, or appears if it newly does belong.
@gnprice gnprice added a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) labels Jun 2, 2023
@gnprice gnprice added this to the Alpha milestone Jun 2, 2023
@gnprice gnprice mentioned this issue Jun 2, 2023
Closed
@gnprice gnprice modified the milestones: Alpha, Launch Sep 22, 2023
@gnprice gnprice mentioned this issue Oct 31, 2023
Open
72 tasks
@gnprice gnprice mentioned this issue May 8, 2024
Merged
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
This was referenced Jun 18, 2024
Merged
Merged
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 21, 2024
@PIG208
message: Handle UpdateMessageEvent for moving.
fbe0f8d 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 21, 2024
@PIG208
message: Handle UpdateMessageEvent for moving.
3f14b06 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 21, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
29a4249 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 22, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
6b326ba 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 25, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
6a317d0 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 25, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
dc4aaeb 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 25, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
0942f02 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 25, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
d0a65a4 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 25, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
e0513fd 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 26, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
0ea27cb 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 26, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
6360b40 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 26, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
4f5b785 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 26, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
1ce22d1 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@gnprice gnprice mentioned this issue Jun 26, 2024
Merged
2 tasks
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Handle UpdateMessageEvent for moving/editing.
a41cce8 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Update editState on events.
87eab20 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Update editState on events.
88384ae 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Update editState on events.
a5e041e 
When a channel (a.k.a stream) or a topic gets updated on a message, we
get a UpdateMessageEvent from the server. The same happens when the
message's content is updated.

This updates the edit state to show the "edited" or "moved" marker
properly on the messages affected, and leave other move related states
(like streamId) untouched until we get to zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 12, 2024
@PIG208
msglist: Monitor and handle narrow updates from model.
3a8b2b7 
See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 12, 2024
@PIG208
msglist: Monitor and handle narrow updates from model.
72dc43f 
See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 12, 2024
@PIG208
msglist: Monitor and handle narrow updates from model.
1b319ab 
See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 12, 2024
@PIG208
msglist: Monitor and handle narrow updates from model.
fe0bc78 
See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 12, 2024
@PIG208
msglist: Monitor and handle narrow updates from model.
fd35ea4 
See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@gnprice gnprice mentioned this issue Jul 17, 2024
Merged
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 19, 2024
@PIG208
msglist: Monitor and handle narrow updates from model.
02fec92 
See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 24, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
e3f4de1 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 24, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
cab55dc 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 24, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
2c333d5 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 25, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
f47454f 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 25, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
553c322 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 26, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
857dd39 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 26, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
e3591e8 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 26, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
e2320e6 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 26, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
520d908 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@gnprice
Copy link
Member Author

gnprice commented Jul 27, 2024

This will be mostly covered by #787. But after that lands, we should follow up with a quick scan to identify anything else that needs updating on message moves — there are several new data structures in the store that we've merged in recent weeks.

@gnprice gnprice mentioned this issue Jul 27, 2024
Open
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 27, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
b84540f 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
a481a14 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
b3ddf04 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
65bac08 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
220ce6d 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
b5be373 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
ad86478 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
499bbfc 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
6664079 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
e37fc5b 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
d261673 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to gnprice/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Update narrow when propageMode is changeAll or changeLater.
b57ca78 
We only implement navigation change for the TopicNarrow. For StreamNarrow,
propagateMode is practically unused.

See also:

  zulip/zulip-mobile#5251

Fixes: zulip#150.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PIG208 PIG208

Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Projects
Flutter app
Status: No status
Milestone
Beta 3: Summer 2024
Development

No branches or pull requests
2 participants
@gnprice @PIG208