Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete: Sort user-mention autocomplete results #228

Open
chrisbobbe opened this issue Jul 19, 2023 · 2 comments
Open

autocomplete: Sort user-mention autocomplete results #228

chrisbobbe opened this issue Jul 19, 2023 · 2 comments
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images

Comments

@chrisbobbe
Copy link
Collaborator

Perhaps by name, to start with, but really:

#207 (review)

(Or better yet something more relevant than name: some kind of relevance to search plus relevance to the context, like people subscribed to the stream or that have talked recently in the narrow. But sorting by user ID seems like it's just going to feel weird and arbitrary to people.)

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Jul 19, 2023
@gnprice gnprice added this to the Launch milestone Jul 19, 2023
@gnprice gnprice modified the milestones: Launch, Beta 3 Nov 22, 2023
@sm-sayedi
Copy link
Collaborator

I would like to work on this one!

So far I've made it sorted by the name.

Before After

@gnprice
Copy link
Member

gnprice commented Mar 27, 2024

@sm-sayedi Sure, please do — assigning to you.

I think a good behavior to shoot for here would be to sort it the same way Zulip web does. There might be things that can be improved there, but if so then they should probably be changed there too. Two particular things I believe it uses that would be helpful:

  • people who've recently participated in the conversation you're looking at get shown sooner
  • people who you've had DM conversations with get shown sooner

In general we keep less message history in the mobile client than the web client, because of the different context, so that might affect what information we have for implementing some of the same features.

But if there are other kinds of data that would help implement the same features as web, and that we don't currently track in the store but are part of the /api/register-queue response, then we can take this as a prompt to add those to our API bindings and start tracking them in the store, as part of implementing this issue.

And as usual, if anything seems uncertain or you have any questions as you're going about that, please ask in #mobile-team and we'll be glad to discuss.

sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 4, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 5, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 5, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 5, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 16, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 16, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 19, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 19, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 29, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 30, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 30, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 1, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 7, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 13, 2024
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 14, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.
  3. Human vs. Bot users.
  4. Alphabetical order.

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 14, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.
  3. Human vs. Bot users.
  4. Alphabetical order.

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 18, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 19, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 20, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 20, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 20, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 21, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 28, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 29, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 31, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 3, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 3, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 4, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 5, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 5, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 5, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 5, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 6, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 6, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 6, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 7, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 7, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 7, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 9, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 10, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
gnprice pushed a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Fixes part of: zulip#228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: No status
Development

No branches or pull requests

3 participants