Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content: Inline code uses paragraph font size, even in headings (h1, etc.) #538

Closed
chrisbobbe opened this issue Feb 29, 2024 · 3 comments · Fixed by #544
Closed

content: Inline code uses paragraph font size, even in headings (h1, etc.) #538

chrisbobbe opened this issue Feb 29, 2024 · 3 comments · Fixed by #544
Assignees
@chrisbobbe
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone
Beta 2

Comments

@chrisbobbe
Copy link
Collaborator

image
@chrisbobbe chrisbobbe added the a-content Parsing and rendering Zulip HTML content, notably message contents label Feb 29, 2024
@chrisbobbe chrisbobbe self-assigned this Feb 29, 2024
@chrisbobbe
Copy link
Collaborator Author

Oh, this is also true of user mentions and timezone-aware times:

image

(Also, for those elements, they aren't getting bolded as they should.)

@gnprice gnprice added this to the Beta 2 milestone Feb 29, 2024
@chrisbobbe chrisbobbe mentioned this issue Feb 29, 2024
Closed
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Feb 29, 2024
@chrisbobbe
content [nfc]: Pass surrounding span style to some elements that want it
75eb29e 
Inline code, user mentions, and global times are failing to match
the font size of an outer span when the outer span's font size is
different. This is zulip#538.

Pass that style to the code responsible for rendering those
elements, without actually using it. We'll do that next.
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Feb 29, 2024
@chrisbobbe
content: Show code, mentions, and times properly even in headings, etc.
0e2e34e 
In the previous commit, we brought the surrounding span's TextStyle
conveniently near to the code that renders these elements.

Here, we use that TextStyle, fixing zulip#538.

Fixes: zulip#538
This was referenced Feb 29, 2024
Closed
Merged
@gnprice gnprice reopened this Mar 1, 2024
@gnprice
Copy link
Member

gnprice commented Mar 1, 2024

Oops, #541 had a classic GitHub accidental-close phrase 🙂: "doesn't fix #538."

@chrisbobbe
Copy link
Collaborator Author

Agh! Thanks for the catch!

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Mar 1, 2024
@chrisbobbe
content: Show code, mentions, and times properly even in headings etc.
b7422e2 
Fixes: zulip#538
@chrisbobbe chrisbobbe mentioned this issue Mar 1, 2024
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Mar 29, 2024
@chrisbobbe
content: Show code, mentions, and times properly even in headings etc.
ab16013 
Fixes: zulip#538
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Apr 2, 2024
@chrisbobbe
content: Show code/math, mentions, and times properly even in heading…
c5c0e0f 
…s etc.

Fixes: zulip#538
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 1, 2024
@chrisbobbe @gnprice
content: Show code/math, mentions, and times properly even in heading…
1c0bde9 
…s etc.

Fixes: zulip#538
Co-authored-by: Greg Price <greg@zulip.com>
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 7, 2024
@chrisbobbe @gnprice
content: Show code/math, mentions, and times properly even in heading…
1a7b6d1 
…s etc.

Fixes: zulip#538
Co-authored-by: Greg Price <greg@zulip.com>
@gnprice gnprice closed this as completed in 9d951cb May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Flutter app
Status: Done
Milestone
Beta 2
2 participants
@gnprice @chrisbobbe