Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notif: Show organization URL in collapsed notification #569

Closed
gnprice opened this issue Mar 19, 2024 · 0 comments · Fixed by #703
Closed

notif: Show organization URL in collapsed notification #569

gnprice opened this issue Mar 19, 2024 · 0 comments · Fixed by #703
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications beta feedback Things beta users have specifically asked for
Milestone
Beta 3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented Mar 19, 2024 •
edited
Loading

See chat thread.

To implement this, I believe what's needed is to make a "summary notification" and put the information there. See the notifications code in zulip-mobile (in Kotlin, under android/) for comparison.

Better yet would be the Zulip organization's name, rather than URL. That's tracked as a followup issue:
@gnprice gnprice added a-Android Issues specific to Android, or requiring Android-specific work a-notifications beta feedback Things beta users have specifically asked for labels Mar 19, 2024
@gnprice gnprice added this to the Beta 2 milestone Mar 19, 2024
This was referenced Mar 19, 2024
Open
Closed
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Mar 21, 2024
@rajveermalviya
notif: Messaging style notifications on Android
f466d2e 
Fixes: zulip#128
Fixes: zulip#569
Fixes: zulip#579
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Mar 21, 2024
@rajveermalviya
notif: Messaging style notifications on Android
9583b85 
Fixes: zulip#128
Fixes: zulip#569
Fixes: zulip#579
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue May 23, 2024
@rajveermalviya
notif: Create summary notification
eac15b4 
Fixes: zulip#569
Fixes: zulip#571
@rajveermalviya rajveermalviya mentioned this issue May 23, 2024
Merged
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue May 23, 2024
@rajveermalviya
notif: Create summary notification
4eb4ff8 
Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue May 31, 2024
@rajveermalviya
notif: Create summary notification
cc2ebf5 
Reimplement the summary notification implementation
from zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 12, 2024
@rajveermalviya
notif: Create summary notification
23a2cdb 
Reimplement the summary notification implementation
from zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 13, 2024
@rajveermalviya
notif: Create summary notification
e31dd55 
Reimplement the summary notification implementation
from zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 13, 2024
@rajveermalviya
notif: Create summary notification
aa18034 
Reimplement the summary notification implementation
from zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 13, 2024
@rajveermalviya
notif: Create summary notification
94cd4d2 
Reimplement the summary notification implementation
from zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 14, 2024
@rajveermalviya
notif: Create group summary notification
14d52e4 
Make use of Group Summary Notifications to group notifications
based on different realms and also display the respective group
label (which is currently the realm URL).

See:
  https://developer.android.com/develop/ui/views/notifications/group#group-summary

This change is a port of implementation in zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 18, 2024
@rajveermalviya
notif: Create group summary notification
1273a93 
Make use of Group Summary Notifications to group notifications
based on different realms and also display the respective group
label (which is currently the realm URL).

See:
  https://developer.android.com/develop/ui/views/notifications/group#group-summary

This change is a port of implementation in zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 18, 2024
@rajveermalviya
notif: Create group summary notification
b1fdfd8 
Make use of Group Summary Notifications to group notifications
based on different realms and also display the respective group
label (which is currently the realm URL).

See:
  https://developer.android.com/develop/ui/views/notifications/group#group-summary

This change is a port of implementation in zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 19, 2024
@rajveermalviya
notif: Create group summary notification
f8b1184 
Make use of Group Summary Notifications to group notifications
based on different realms and also display the respective group
label (which is currently the realm URL).

See:
  https://developer.android.com/develop/ui/views/notifications/group#group-summary

This change is a port of implementation in zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 19, 2024
@rajveermalviya
notif: Create group summary notification
973d830 
Make use of Group Summary Notifications to group notifications
based on different realms and also display the respective group
label (which is currently the realm URL).

See:
  https://developer.android.com/develop/ui/views/notifications/group#group-summary

This change is a port of implementation in zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 19, 2024
@rajveermalviya
notif: Create group summary notification
9d6f5a8 
Make use of Group Summary Notifications to group notifications
based on different realms and also display the respective group
label (which is currently the realm URL).

See:
  https://developer.android.com/develop/ui/views/notifications/group#group-summary

This change is a port of implementation in zulip-mobile:
  https://github.com/zulip/zulip-mobile/blob/6d5d56d175644cd0cdf47f3cd30ffadf6756bbdc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L299-L382

Fixes: zulip#569
Fixes: zulip#571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: Done
Milestone
Beta 3: Summer 2024
Development

Successfully merging a pull request may close this issue.

notif: Create summary notification rajveermalviya/zulip-flutter
1 participant
@gnprice