test: Adapt to change in [MenuItemButton.onPressed] logic that broke tests #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests Along with 2f0f469, this is a reminder that it'd be good to get our repo added to Flutter's "customer tests" suite: zulip#239. It's also another reminder among several that it'd be good to pin a precise version of Flutter: zulip#15. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Failing.20tests/near/1615254 Related: zulip#15 Related: zulip#239
|
Thanks for taking care of this! Looks good; merging, just tweaking the prefix to "test:" since that's what we've mostly been using. |
gnprice
force-pushed
the
pr-menu-item-button-test-breakage
branch
from
0aab153
to
38ed6c8
Compare
gnprice
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15
Related: #239