model: Implement StreamColorSwatch.lerp, copying ColorSwatch.lerp #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-stream-color-swatch-lerp
branch
from
47368ac
to
233708e
Compare
It's convenient in this method to access the colors as they're stored in a Map, like the superclass ColorSwatch does. So, in our own private field, we save the same Map that we pass along to the superclass constructor. As Greg says at zulip#642 (comment) : > The redundancy is mildly annoying, but it's only duplicating one > pointer, so it's not a material cost at runtime.
|
Cool, with this approach it LGTM — merging. |
gnprice
force-pushed
the
pr-stream-color-swatch-lerp
branch
from
233708e
to
fd58d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done as an alternative to #642.
Related: #95