ui: Adjust app bar bg and scaffold bg colors toward new Figma design #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
a-design
|
Screenshots:
|
chrisbobbe
changed the title
gnprice
reviewed
May 20, 2024
lib/widgets/theme.dart
Outdated
| @@ -14,7 +14,10 @@ ThemeData zulipThemeData(BuildContext context) { | |||
| scrolledUnderElevation: 0, | |||
| backgroundColor: Color(0xfff5f5f5), | |||
|
|
|||
| shape: Border(bottom: BorderSide(color: Color(0xffcccccc))), | |||
| shape: Border(bottom: BorderSide( | |||
| color: Color(0x33000000), | |||
There was a problem hiding this comment.
Now, the app-bar bottom border is colored by the new Figma's
`border-bar`, and the main background color is `bg-main`. The app
bar background is unchanged because it already matches `bg-top-bar`.
This feels like the sort of information that's helpful to have in the code itself, so as a comment something like:
Suggested change
| color: Color(0x33000000), | |
| color: Color(0x33000000), // `border-bar` in Figma |
As part of #95 I think you'll be turning these into some sort of named reference, so that this would be foo.borderBarColor for some foo. That'll be another way of putting this information into the code, which is better than a comment. But until then a comment seems helpful.
|
Thanks! Revision pushed. |
chrisbobbe
force-pushed
the
pr-adjust-app-bar-and-scaffold-background-2
branch
from
eb29d0b
to
00c031a
Compare
…sign From discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20colors/near/1801938 and the Figma linked there: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2074%3A26325&t=rjuqcQaHMiGBUReF-1 Now, the app-bar bottom border is colored by the new Figma's `border-bar`, and the main background color is `bg-main`. The app bar background is unchanged because it already matches `bg-top-bar`. I've labeled these values with comments in the code. And all these color variables have dark-theme variants! (See discussion for what those are.) That'll help when we implement dark theme, zulip#95.
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-adjust-app-bar-and-scaffold-background-2
branch
from
00c031a
to
10d0fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This replaces #682.)
From discussion:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20colors/near/1801938
and the Figma linked there:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2074%3A26325&t=rjuqcQaHMiGBUReF-1
Now, the app-bar bottom border is colored by the new Figma's
border-bar, and the main background color isbg-main. The app bar background is unchanged because it already matchesbg-top-bar.And all these color variables have dark-theme variants! (See discussion for what those are.) That'll help when we implement dark theme, #95.