Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notif: Use Zulip's notification sound on Android #717

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajveermalviya
Copy link
Collaborator

Updates #340

For now, only includes the default sound, i.e. it doesn't show multiple sound options in notification settings - this will be done in later PRs.


// Delete any older channels.
var found = false;
final channels = await androidPlugin.getNotificationChannels();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than add more parts of the package:flutter_local_notifications API that we use, let's use Pigeon for this. That way in order to be confident of understanding what the code is doing, we only have to read our own code and the Android docs, and not also the flutter_local_notifications code 🙂 (which often introduces a lot of logic of its own).

As a concrete strategy, let's put this issue after #351: so we convert the existing call sites first (the remaining ones, after #592 covered the most complex of them), and then we go on to add Pigeon bindings for more of the notifications API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants