notif: Support messaging-style notifications #718
+572
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
force-pushed
the
messaging-style-notif
branch
from
0e3d32c
to
b61ad25
Compare
rajveermalviya
force-pushed
the
messaging-style-notif
branch
4 times, most recently
from
cbab765
to
042a89e
Compare
rajveermalviya
commented
Jun 25, 2024
|
|
||
| fun toPigeonPerson(person: androidx.core.app.Person): Person { | ||
| return Person( | ||
| null, // TODO: Serialize icon maybe using content URI, mData is not exposed. |
There was a problem hiding this comment.
Currently, we don't return Person's IconData back when returning active notification (via getActiveNotificationMessagingStyleByTag) because we don't seem to have an API to get data bytes back.
Fortunately though it doesn't seem to be necessary because in my local testing, the avatar is correctly visibile even when same sender has multiple messages, which makes sense because here's what ends up happening:
MessagingStyle(
user: Person('You')
messages: [
MessagingStyleMessage(content: '...',
person: Person(key: id1, name: 'John', iconData: null)), // Old, got from active notif
MessagingStyleMessage(content: '...',
person: Person(key: id1, name: 'John', iconData: null)), // Old, got from active notif
MessagingStyleMessage(content: '...',
person: Person(key: id1, name: 'John', iconData: [...])), // Latest message, newly added
],
...
)So, Android seems to be okay with older messages not having iconData for a specific Person.
Khader-1
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Thank you, @rajveermalviya! The code looks good to me. The manual test as well as the attached video demonstrate that the behavior described in the issue has been correctly addressed.
Khader-1
added
mentor review
Add methods and types for creating messaging style notifications: https://developer.android.com/develop/ui/views/notifications/build-notification#messaging-style
rajveermalviya
force-pushed
the
messaging-style-notif
branch
from
042a89e
to
1998fb1
Compare
Use messaging style notifications to display messages with sender's name and avatars, along with support for displaying multiple messages from a specific topic by updating existing notification from notifications panel. See: https://developer.android.com/develop/ui/views/notifications/build-notification#messaging-style This change is similar to existing implementation in zulip-mobile: https://github.com/zulip/zulip-mobile/blob/e352f563ecf2fa9b09b688d5a65b6bc89b0358bc/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L177-L309 Fixes: zulip#128
rajveermalviya
force-pushed
the
messaging-style-notif
branch
from
1998fb1
to
3285d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after.mp4
Fixes: #128