Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing message topic only moves one message #4828

Open
WesleyAC opened this issue Jun 24, 2021 · 2 comments
Open

Editing message topic only moves one message #4828

WesleyAC opened this issue Jun 24, 2021 · 2 comments
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending experimental UI/UX To be user-tested in experimental build help wanted webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@WesleyAC
Copy link
Contributor

When you edit a message topic in mobile, it only moves the one message. On web, we give three options:

  • Change later messages to this topic
  • Change only this message topic
  • Change previous and following messages to this topic

We should offer these options. Probably the best UI for this is to just pop up a modal when the user clicks the checkmark button to submit the edit, since I think it's likely to be too crowded elsewhere. (That'll also make sure that the edit of the topic wasn't inadvertent)

@WesleyAC WesleyAC added a-compose/send Compose box, autocomplete, camera/upload, outbox, sending experimental UI/UX To be user-tested in experimental build webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. labels Jun 24, 2021
@gnprice
Copy link
Member

gnprice commented Aug 17, 2021

I agree with that plan about the UI.

Adding this feature should probably block on fixing #2688 (and in particular its symptom #4830.) That issue makes the experience of editing the message topic feel pretty broken -- if you're looking in a topic narrow, the message doesn't actually disappear from the message list -- and so I feel like making it easier / more natural to go editing topics would increase the annoyance there.

@gnprice gnprice added the blocked on other work To come back to after another related PR, or some other task. label Aug 17, 2021
@chrisbobbe
Copy link
Contributor

#2688 has been fixed, so I'll mark this as unblocked.

@chrisbobbe chrisbobbe removed the blocked on other work To come back to after another related PR, or some other task. label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending experimental UI/UX To be user-tested in experimental build help wanted webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Development

No branches or pull requests

3 participants