Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need warning before unsubscribing from a private stream. #5553

Open
Tignus opened this issue Nov 15, 2022 · 7 comments
Open

Need warning before unsubscribing from a private stream. #5553

Tignus opened this issue Nov 15, 2022 · 7 comments
Assignees
Labels
a-stream settings/subs Creating streams, subscribing, editing settings help wanted webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@Tignus
Copy link

Tignus commented Nov 15, 2022

This issue has been fixed in the webapp.

I'm opening it here so it can be tracked on the mobile app.

Right now it is quite easy to get locked out of your own private stream.

@gnprice gnprice added help wanted a-stream settings/subs Creating streams, subscribing, editing settings webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. labels Nov 15, 2022
@arijitghosal03
Copy link

I would love working on this issue
@zulipbot claim

@alya
Copy link
Collaborator

alya commented Nov 16, 2022

@arijitghosal03 please post a comment describing your proposed approach when you're ready. I can assign the issue to you once you have a rough plan. Thanks!

@arijitghosal03
Copy link

arijitghosal03 commented Nov 17, 2022

@alya
This problem was already fixed in the web app design. My plan intends to implement the same warning notification through some frontend conditional code which will rest of the operations same as it is if the user chooses "Confirm" else (i.e. "Cancel") will redirect him to the previous window.
The issue can be thus resolved by these code changes and I will be glad to work on this.
Thank You
warning message

@alya
Copy link
Collaborator

alya commented Nov 23, 2022

Thanks! @chrisbobbe @gnprice FYI, in case you have any feedback on the above plan.

@arijitghosal03
Copy link

@alya added an alert option before unsubsribing from streams,
committed the changes,waiting for review.

@neerajbachani

This comment was marked as off-topic.

@gnprice

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-stream settings/subs Creating streams, subscribing, editing settings help wanted webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Development

No branches or pull requests

5 participants