-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to disable debug.log #1066
Comments
@mistersmee While I mainly run this from the same directory I definitely can agree with you on this 👍 We have a plan to move to using However, independently of this plan, debug.log should have little output in most cases, so I'm going to see if there's a quick resolution to this where we don't create it until it's needed. |
Installed using pip, so, not the git version.
That would be awesome! I currently have an alias that basically does the same thing,
I mainly stay in
Sure, thanks! With that I'd say the issue is resolved, so I'll close it. |
@mistersmee Thanks for being proactive in closing this, but I'm going to reopen this for now to see if we can avoid outputting until we write to the file, like we do with other log-files, or until we have #678 resolved. |
@mistersmee Just a note that we keep the git version fairly stable and there are some good new features there you might enjoy :) |
Tests amended. Fixes zulip#1066.
To centralize the specification of the logging file, this is now set in `run.py` and passed into the controller as an `Optional[str]` argument. Tests amended. Fixes zulip#1066.
To centralize the specification of the logging file, this is now set in `run.py` and passed into the controller as an `Optional[str]` argument. Tests amended. Fixes #1066.
@mistersmee I'm sure you'll get a notification this is resolved (by #1122) and now only opens the file in debug mode. |
Pretty cool! This should help in keeping my homedir clean, thanks! |
Currently,
debug.log
is created wherever the current directory is, and if there are no errors, it is a 0B empty file, even if zulip-term is launched without the-d
flag.I would like the creation of
debug.log
to be tied to that-d
flag, as it gets messy and annoying after a while, deleting that file again and again, i.e. if the debug flag is passed then use debug.log, else don't create it.If not that, then at least an option to disable creating that file.
The text was updated successfully, but these errors were encountered: