Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasize heading titles in messages #1095

Closed
neiljp opened this issue Jul 23, 2021 · 14 comments · Fixed by #1146
Closed

Emphasize heading titles in messages #1095

neiljp opened this issue Jul 23, 2021 · 14 comments · Fixed by #1146
Labels
area: message rendering good first issue Good for newcomers
Milestone
0.7.0

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jul 23, 2021

It's possible to indicate "headings" at different levels, akin to h1-h6 in html, using markdown - this currently just appears as plain text.

This would be a good issue for someone new; here are some suggestions for implementation:

  • identify the html generated by the server (inspect in the browser)
  • examine the existing tests for soup2markup and think how they'd be extended
  • add heading styles in themes (and required styles) and add a case to the soup2markup test (this new test should fail)
  • explore where the code needs adding in soup2markup; add it and ensure the test now passes :)
  • test manually in #test here on chat.zulip.org :)
  • file a PR :)

A later addition would be to add support for multiple levels of heading, such as re-adding the number of leading #'s, or some other design.

Please check-in on #zulip-terminal on chat.zulip.org if you have questions :)
@neiljp neiljp mentioned this issue Jul 23, 2021
Open
12 tasks
@SwarupKharul
Copy link
Collaborator

I would like to work on this issue, please assign it to me!

@neiljp
Copy link
Collaborator Author

neiljp commented Aug 16, 2021

@SwarupKharul Just calling out like you've done is fine, though you can use @zulipbot claim to handle this yourself on Zulip repositories :)

@SwarupKharul
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @SwarupKharul! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@kingjuno
Copy link
Collaborator

@SwarupKharul if u aren't working on this, may I take this issue?

@zulipbot
Copy link
Member

zulipbot commented Sep 5, 2021 •
edited

Hello @SwarupKharul, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@avats-dev
Copy link
Collaborator

@kingjuno what about this one?

@kingjuno
Copy link
Collaborator

kingjuno commented Sep 13, 2021 •
edited

@avats-dev I am not working on this. I guess you can go with this one.

@mounilKshah
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Dec 9, 2021

Welcome to Zulip, @mounilKshah! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Dec 19, 2021 •
edited

Hello @mounilKshah, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@mounilKshah
Copy link
Collaborator

Hello,
Sorry for not having updated this issue.
It is actually my first time working on an open source issue. I have decided to work on the heading-styles of the messages first. Before starting with anything, I went through the conversation on #feedback stream on Zulip developers' server, to understand what is expected.
I have gone through the developer-feature-tutorial.md and developer-file-overview.md to get an overview of the project. I will try to complete the implementation of various heading styles within this week itself.

@mounilKshah
Copy link
Collaborator

@zulipbot claim

@mounilKshah
Copy link
Collaborator

mounilKshah commented Dec 27, 2021 •
edited

Hello @neiljp
I tried looking for libraries which would allow the change in font size. However, all I could find was results which said that the only way to change font size in terminal is the user settings, ie, only the user can change the font size.
Hence, I thought of emphasising the heading by changing its colour in the terminal.

Before heading-style implementation:

Screenshot 2021-12-27 at 18 26 01

After heading-style implementation:

Screenshot 2021-12-27 at 18 26 47

At present, I have implemented this only in the zt_dark theme. Also, all the heading-styles have the same implementation at present.

I wanted to ask if these changes are fine and should I continue to implement similar changes in the remaining themes as well or not.

Here is the commit containing the changes made by me

mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Dec 28, 2021
@mounilKshah
theme: add heading-style for zt_dark
22a17fb 
In order to emphasise the heading tags ranging from h1 to h6, they have been displayed with a different colour. This is to fix issue zulip#1095
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Dec 31, 2021
@mounilKshah
themes: Add heading-style for gruvbox and zt_blue themes. Fixes zulip…
25fbdc0 
…#1095

This commit along with ed3227b and 22a17fb implement heading-styles for all the themes.
h1 to h6 styles have the same implementation of 'msg_heading' in the respective themes as of now.
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Dec 31, 2021
@mounilKshah
themes: Add heading-style for gruvbox and zt_blue themes. Fixes issue z…
560d601 
…ulip#1095

This commit along with ed3227b and 22a17fb implement heading-styles for all the themes.
h1 to h6 styles have the same implementation of 'msg_heading' in the respective themes as of now.
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Dec 31, 2021
@mounilKshah
themes: Add heading-style for gruvbox and zt_blue themes, fixes zulip…
1d62c36 
…#1095

This commit along with ed3227b and 22a17fb implement heading-styles for all the themes.
h1 to h6 styles have the same implementation of 'msg_heading' in the respective themes as of now.
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Dec 31, 2021
@mounilKshah
themes: Add heading-style for gruvbox and zt_blue themes.
ea2b711 
This commit along with ed3227b and 22a17fb implement heading-styles for all the themes.
h1 to h6 styles have the same implementation of 'msg_heading' in the respective themes as of now.
Fixes zulip#1095
@mounilKshah mounilKshah mentioned this issue Dec 31, 2021
Merged
4 tasks
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Jan 1, 2022
@mounilKshah
themes: Add test case for heading-style in soup2markup
75170f7 
This commit contains the changes required to pass all the pre-existing test cases
It also contains the test case for heading-style in soup2markup as requested in
the zulip#1095. Fixes zulip#1095.
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Jan 2, 2022
@mounilKshah
themes: Add heading-style for all themes. Update and add test cases.
f92b59b 
Heading-style added for all themes.
Tests updated and new test cases added under test_soup2markup.
Fixes zulip#1095.
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Jan 7, 2022
@mounilKshah
themes: Add heading-style for all themes.
942aff7 
Heading-style added for all themes.
Tests updated and new test cases added under test_soup2markup.
Fixes zulip#1095.
@mounilKshah mounilKshah mentioned this issue Jan 11, 2022
Open
@neiljp neiljp closed this as completed in 1689e9c Jan 18, 2022
@neiljp neiljp added this to the Next Release milestone Jan 18, 2022
@mounilKshah mounilKshah removed their assignment Jan 20, 2022
Dishti-Oberai pushed a commit to Dishti-Oberai/zulip-terminal that referenced this issue Feb 2, 2022
@mounilKshah @Dishti-Oberai
themes/boxes: Add msg_heading style to themes & render message headings.
9e14bbe 
New test cases added under test_soup2markup.

Fixes zulip#1095.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: message rendering good first issue Good for newcomers
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Added heading-style for all the four themes mounilKshah/zulip-terminal
6 participants
@neiljp @zulipbot @avats-dev @mounilKshah @SwarupKharul @kingjuno