Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added heading-style for all the four themes #1146

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

mounilKshah
Copy link
Collaborator

@mounilKshah mounilKshah commented Dec 31, 2021

What does this PR do?
This PR emphasises the headings present in the message.
Fixes #1095

Discussion on the dev community:
#zulip-terminal> Emphasising heading styles #T1095

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • Only one commit which contains all the changes made and the test cases updated and added for heading-styles.

Notes & Questions

  • Tests have been added for the heading styles.
  • This PR resolves the #T1095
  • At present, h1-h6 have the same implementation for a particular theme.

Visual changes

After implementing the heading-styles:

zt_dark

zt_dark

zt_light

zt_light

zt_blue

zt_blue

gruvbox

gruvbox

@zulipbot zulipbot added size: S [Automatic label added by zulipbot] area: message rendering labels Dec 31, 2021
@prah23
Copy link
Member

prah23 commented Jan 1, 2022

Thanks for submitting this pull request, @mounilKshah.
I'd suggest modifying the commits (and their messages) to suit this project's format. The tests for the changes are expected to be present in the same commit as the changes themselves. The current commit structure can be modified to lesser commits in a more coherent form. You can take a look at Zulip's commit discipline documentation for guidance with structuring your commits and our project's commit style section for suggestions on improving your commit messages.

@mounilKshah mounilKshah force-pushed the add-heading-style branch 4 times, most recently from f92b59b to 942aff7 Compare January 7, 2022 11:17
Copy link
Member

@prah23 prah23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @mounilKshah, looks good to me. 👍

@neiljp neiljp merged commit 1689e9c into zulip:main Jan 18, 2022
@neiljp
Copy link
Collaborator

neiljp commented Jan 18, 2022

@mounilKshah Thanks for working on this 👍 I've slightly simplified the commit text but have otherwise merged as you had it 🎉

@neiljp neiljp added this to the Next Release milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message rendering size: S [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emphasize heading titles in messages
4 participants