Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reporting upon moving/splitting topics #1172

Closed
neiljp opened this issue Mar 18, 2022 · 2 comments · Fixed by #1196
Closed

Improve reporting upon moving/splitting topics #1172

neiljp opened this issue Mar 18, 2022 · 2 comments · Fixed by #1196
Labels
area: message editing area: UI General user interface update enhancement New feature or request good first issue Good for newcomers
Milestone
0.7.0

Comments

@neiljp
Copy link
Collaborator

neiljp commented Mar 18, 2022

Currently a message is given to the user when a topic is moved, but we could give more information about this:

  • where from?
  • where to?
  • how many? (all? some?)

For the first version of this, updating the text we output would be sufficient.

As a follow-up, we could consider if there are other ways to indicate eg. split topics.

For comparison, the web app appears to intentionally not sort after splitting topics, to leave both parts in view, whereas ZT does so.
@neiljp neiljp added enhancement New feature or request good first issue Good for newcomers area: UI General user interface update area: message editing labels Mar 18, 2022
@srdeotarse
Copy link
Collaborator

@zulipbot claim

@srdeotarse srdeotarse mentioned this issue Mar 24, 2022
Merged
4 tasks
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Mar 24, 2022
@srdeotarse
model: Improve reporting upon moving topic.
a448fab 
Tests modified.

Fixes zulip#1172
@zulipbot
Copy link
Member

zulipbot commented Apr 1, 2022 •
edited

Hello @srdeotarse, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 11, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/splitting topics.
fa29ec6 
Partially fixes zulip#1172
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 11, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/splitting topics.
2fba636 
Partially fixes zulip#1172
@srdeotarse srdeotarse mentioned this issue Apr 11, 2022
Merged
4 tasks
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 12, 2022
@srdeotarse
model: Highlight stream and topic reporting of moving/splitting topics.
e96594c 
Partially fixes zulip#1172
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 14, 2022
@srdeotarse
core/model: Highlight stream in reporting of moving/splitting topics.
32b0717 
Partially fixes zulip#1172

Tests updated.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 14, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/splitting topics.
28b5f9f 
Partially fixes zulip#1172

Tests updated.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 16, 2022
@srdeotarse
core/model: Highlight stream and topic reporting moving/splitting topic.
c0bbffd 
Partially fixes zulip#1172
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 16, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/splitting topics.
b44090a 
Partially fixes zulip#1172

Tests updated.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 20, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/splitting topics.
c2e644b 
Partially fixes zulip#1172
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 20, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/spliting topics.
2662ae7 
Partially fixes zulip#1172
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 20, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/spliting topics.
d14f51d 
Partially fixes zulip#1172
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 20, 2022
@srdeotarse
model: Highlight stream name in reporting of moving/spliting topics.
648b188 
Partially fixes zulip#1172
neiljp pushed a commit to srdeotarse/zulip-terminal that referenced this issue Apr 21, 2022
@srdeotarse @neiljp
model: Highlight stream & topic in reporting of moving/spliting topics.
dc5ba6b 
Tests updated.

Partial fix towards zulip#1172.
neiljp pushed a commit that referenced this issue Apr 21, 2022
@srdeotarse @neiljp
model: Highlight stream & topic in reporting of moving/spliting topics.
5b43ca5 
Tests updated.

Partial fix towards #1172.
@neiljp neiljp added this to the Next Release milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: message editing area: UI General user interface update enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

model: Highlight stream name in reporting of moving/splitting topics. srdeotarse/zulip-terminal
3 participants
@neiljp @zulipbot @srdeotarse