Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create extended user mention syntax when needed. #151

Closed
aero31aero opened this issue Sep 26, 2018 · 5 comments · Fixed by #928
Closed

Create extended user mention syntax when needed. #151

aero31aero opened this issue Sep 26, 2018 · 5 comments · Fixed by #928
Labels
area: autocomplete high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client
Milestone
0.7.0

Comments

@aero31aero
Copy link
Member

Recently, in zulip/zulip#10243 we merged support for the following mention syntax to zulip/zulip:

@**Full Name|1234(id)**

This is to allow us to mention users with the same full name, and is optional. The web app intelligently adds the new syntax only when the users have the same full name, and uses the simpler syntax for others.

Example: https://chat.zulip.org/#narrow/stream/7-test-here/topic/user.20mention

We should:

  1. Add support for this syntax in the terminal client.
  2. Ensure that it is behind a feature flag because it would break mentions in older servers/any non CZO server for now.
@timabbott
Copy link
Sponsor Member

We can do a check against the server version being 1.9.0 or greater, for this.

@amanagr amanagr added enhancement New feature or request high priority should be done as soon as possible labels Sep 30, 2018
@neiljp
Copy link
Collaborator

neiljp commented Oct 24, 2018

I started to look into this and it seems that ZT uses the rendered text provided by the app to understand mentions from the server - the linked example renders OK as-is? So not the same issue as in the python lib.

If the change is indeed primarily regarding sending to capable servers, this only currently appears relevant to using '@' to reply with a quote? (though it would be useful to support 'x' - compose message - from the users search bar too)

@neiljp neiljp added the GSoC Possible GSoC project component label May 3, 2020
@zee-bit zee-bit mentioned this issue Dec 31, 2020
Closed
@zee-bit
Copy link
Member

zee-bit commented Mar 13, 2021

@neiljp This issue seems to be fixed by #854, should we close this?

@neiljp neiljp removed the GSoC Possible GSoC project component label Mar 13, 2021
@neiljp
Copy link
Collaborator

neiljp commented Mar 13, 2021

This is now likely pending on #928.

@zee-bit
Copy link
Member

zee-bit commented Mar 13, 2021

Ahh...sorry. It was user mention syntax and not the quoting syntax we recently merged. :)

@prah23 prah23 mentioned this issue Mar 29, 2021
Merged
prah23 added a commit to prah23/zulip-terminal that referenced this issue Mar 29, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
4b7371b 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
prah23 added a commit to prah23/zulip-terminal that referenced this issue Mar 29, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
7172b8f 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
prah23 added a commit to prah23/zulip-terminal that referenced this issue Jun 7, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
85abbf6 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
prah23 added a commit to prah23/zulip-terminal that referenced this issue Jun 7, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
7a9cb8f 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
prah23 added a commit to prah23/zulip-terminal that referenced this issue Jun 11, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
1d87807 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
prah23 added a commit to prah23/zulip-terminal that referenced this issue Jun 11, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
aede198 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
prah23 added a commit to prah23/zulip-terminal that referenced this issue Jun 11, 2021
@prah23
boxes: Use user_ids in autocomplete for ambiguous user mentions.
ecbbc64 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes zulip#151.
neiljp pushed a commit that referenced this issue Jun 11, 2021
@prah23 @neiljp
boxes: Use user_ids in autocomplete for ambiguous user mentions.
9280f09 
Prior to this commit, user mentions through autocomplete used only
names in the typeahead. This commit appends `user_id`s to all the
multiple instances of the same name to use the **Name|User_id** format of
user mentions.

This is done by using collections.Counter to check the count of each user
name in the users list. The user_id is appended to names that have a count
greater than 1. The appended user_id would serve as a distinction
between users having the same name.

Tests added and updated.

Fixes #151.
@neiljp neiljp added this to the Next Release milestone Jun 11, 2021
@neiljp neiljp added missing feature: user A missing feature for all users, present in another Zulip client and removed enhancement New feature or request labels Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: autocomplete high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

boxes: Use user_ids in autocomplete for user mentions. prah23/zulip-terminal
5 participants
@timabbott @aero31aero @neiljp @amanagr @zee-bit