Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display '(You)' beside logged-in-user in user list. #437

Closed
sumanthvrao opened this issue Jul 19, 2019 · 25 comments
Closed

Display '(You)' beside logged-in-user in user list. #437

sumanthvrao opened this issue Jul 19, 2019 · 25 comments
Assignees
@Astronag
Labels
good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress

Comments

@sumanthvrao
Copy link
Member

It would benefit to mark users who has logged-in (yourself) with a slightly different style compared to the rest of the users active (marked in yellow). Currently, we distinguish this subtly as the user name is the top name in the list.

One method was to mark (YOU) beside the logged in person, which is what the Web-app uses to distinguish. White color would be preferable.

We handle the logic of storing and sorting the user list in get_all_users in model.py, Which is likely the function to which the text must be added. Further, coloring schemes can be found in config/themes.py to be used for this.

In case of getting stuck, feel free to join us in #zulip-terminal on chat.zulip.org
@sumanthvrao sumanthvrao added the good first issue Good for newcomers label Jul 19, 2019
@sumanthvrao sumanthvrao changed the title Display '(You)` beside logged-in-user in user list. Display '(You)' beside logged-in-user in user list. Jul 19, 2019
@amanagr amanagr added the help wanted This issue should be clear enough to work on label Jul 19, 2019
@tarangchikhalia
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @tarang93ch! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@khizirsiddiqui
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

Hello @khizirsiddiqui, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it.

We look forward to your valuable contributions!

@khizirsiddiqui khizirsiddiqui mentioned this issue Aug 25, 2019
Closed
@zulipbot
Copy link
Member

zulipbot commented Sep 7, 2019 •
edited

Hello @tarang93ch, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@khizirsiddiqui
Copy link

khizirsiddiqui commented Sep 10, 2019 •
edited

@zulipbot abandon
A little busy with academics. Won't be able to continue for few weeks.

@TaranSinghania
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Oct 6, 2019

Welcome to Zulip, @TaranSinghania! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@TaranSinghania
Copy link
Collaborator

@khizirsiddiqui , are you still working on this?

@khizirsiddiqui
Copy link

@TaranSinghania no, I'm busy with some other work, won't be able to complete in near future. Feel free to take it up.

@TaranSinghania
Copy link
Collaborator

@zulipbot abandon

@Milind712000
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jan 1, 2020

Welcome to Zulip, @Milind712000! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@Milind712000
Copy link
Collaborator

@zulipbot abandon

Astronag added a commit to Astronag/zulip-terminal that referenced this issue Sep 25, 2020
@Astronag
Fixes zulip#437, buttons: Added display_postfix_text() method to disp…
27a09ec 
…lay '(you)' beside logged-in-user in user list
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Sep 25, 2020
@Astronag
Fixes zulip#437, themes: Added new style to color '(you)' displayed b…
2f5ebb3 
…eside logged-in-user in user list
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Sep 25, 2020
@Astronag
Fixes zulip#437, test_ui_tools: Modified test_users_view() method to …
f220f81 
…allow displaying '(you)' beside logged-in-user in user list
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Sep 26, 2020
@Astronag
buttons/views/test_ui_tools: Displays '(you)' beside current user's u…
a57df60 
…sername.

Fixes zulip#437
@zulipbot
Copy link
Member

zulipbot commented Oct 4, 2020 •
edited

Hello @Astronag, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 7, 2020
@Astronag
buttons/themes/views/test_ui_tools: Display '(you)' beside logged-in-…
2bbb6c4 
…user in user list.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 7, 2020
@Astronag
buttons/views/test_ui_tools: Displays '(you)' beside current user's u…
d694804 
…sername.

Fixes zulip#437
@Astronag
Copy link
Collaborator

@zulipbot claim

Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/themes/views/test_ui_tools: Display '(you)' beside logged-in-…
39eba68 
…user in user list.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/test_ui_tools: Displays '(you)' beside current user's u…
ef564a5 
…sername.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
refactor: buttons: Used a Tuple to display unread count in update_wid…
b6a880b 
…get().

A Tuple of style and text is used instead of a string to display the count of unread messages.
Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/test_ui_tools: Displays '(you)' beside current user's u…
9e4a814 
…sername.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
refactor: buttons: Used a Tuple to display unread count in update_wid…
d68bce9 
…get().

A Tuple of style and text is used instead of a string to display the count of unread messages.
Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/test_ui_tools: Displays '(you)' beside current user's u…
5013326 
…sername.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
refactor: buttons: Used a Tuple to display unread count in update_wid…
c9de3f5 
…get().

A Tuple of style and text is used instead of a string to display the count of unread messages.
Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
7f0443b 
…ser's username.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
refactor: buttons: Used a Tuple to display unread count in update_wid…
38672b5 
…get().

A Tuple of style and text is used instead of a string to display the count of unread messages.
Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
861a258 
…ser's username.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
refactor: buttons: Used a Tuple to display unread count in update_wid…
899a1bb 
…get().

A Tuple of style and text is used instead of a string to display the count of unread messages.
Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
7378925 
…ser's username.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
a591cf6 
…ser's username.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
10ad825 
…ser's username.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
c2c2f70 
…ser's username.

Fixes zulip#437
Astronag added a commit to Astronag/zulip-terminal that referenced this issue Oct 22, 2020
@Astronag
buttons/views/themes/test_ui_tools: Displays '(you)' beside current u…
6868201 
…ser's username.

Fixes zulip#437
@neiljp neiljp closed this as completed in ad8130a Oct 22, 2020
@neiljp
Copy link
Collaborator

neiljp commented Oct 22, 2020

Thanks to all those who worked on this; I just merged @Astronag 's version so will close the other PRs shortly, but I hope you learned from working on your contributions and will consider others in future, whether in ZT or other projects 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Astronag Astronag

Labels
good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress
Projects
None yet
Milestone
No milestone