Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Enable view of user info #511

Closed
SGeetansh opened this issue Feb 23, 2020 · 5 comments · Fixed by #848
Closed

Feature: Enable view of user info #511

SGeetansh opened this issue Feb 23, 2020 · 5 comments · Fixed by #848
Labels
good first issue Good for newcomers missing feature: user A missing feature for all users, present in another Zulip client
Milestone
0.7.0

Comments

@SGeetansh
Copy link
Collaborator

Just like the stream descriptions, on pressing i, while a user is in focus, the full description of the user should pop-up which must include the information available in the View full profile section on the web app.
@SGeetansh
Copy link
Collaborator Author

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Mar 4, 2020 •
edited

Hello @SGeetansh, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@SGeetansh SGeetansh mentioned this issue Mar 4, 2020
Closed
@sumanthvrao sumanthvrao added the enhancement New feature or request label Mar 7, 2020
SGeetansh added a commit to SGeetansh/zulip-terminal that referenced this issue Mar 8, 2020
@SGeetansh
Fixes zulip#511: Press 'i' to show user info
00db9c0
@neiljp neiljp added the good first issue Good for newcomers label Oct 20, 2020
@Ezio-Sarthak
Copy link
Member

@neiljp Going through the code base, I am unable to find how are we fetching full user profile data (as displayed in the web app). This seems interesting to me!

@neiljp
Copy link
Collaborator

neiljp commented Dec 7, 2020

@SGeetansh Do you expect to continue your work on this soon?

@Ezio-Sarthak We don't currently have the data stored in the app - I believe it is fetched on demand as per the linked PR here. There may be a method in the python API we can use instead however. For a first version it may be wise to fetch the basic information, before determining how to handle custom fields (which vary per server) in a later version.

This was referenced Dec 10, 2020
Closed
Merged
@Ezio-Sarthak
Copy link
Member

Ezio-Sarthak commented Dec 11, 2020 •
edited

@neiljp This PR #848 needs review :)

Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Dec 18, 2020
@Ezio-Sarthak
feature: buttons/views/test_popups: Integrate user info view.
0f6733a 
Add user info view to both users list and message info view.
Tests of message info view updated accordingly.
Fixing zulip#511
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Dec 18, 2020
@Ezio-Sarthak
feature: buttons/views/test_popups: Integrate user info view.
bf698ef 
Add user info view to both users list and message info view.
Tests of message info view updated accordingly.
Fixing zulip#511
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Dec 23, 2020
@Ezio-Sarthak
tests: test_popups: Test for user info view added.
2b5d88a 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Dec 24, 2020
@Ezio-Sarthak
tests: test_popups: Test for user info view added.
cab7b28 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 3, 2021
@Ezio-Sarthak
tests: test_popups: Test for user info view added.
6d77503 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 4, 2021
@Ezio-Sarthak
core: User's last activity status improved.
df964b1 
Last activity improvements:
- Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
- All timestamps before 2 weeks are returned as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Test added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 6, 2021
@Ezio-Sarthak
core: User's last activity status improved.
af34576 
Last activity improvements:
- Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
- All timestamps before 2 weeks are returned as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Test added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 7, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
f49e704 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Test added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 7, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
cb1a099 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Test added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 7, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
3e1741e 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Tests added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 13, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
b7c8156 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Tests added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 13, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
00aac6a 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Tests added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 16, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
66c377c 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Tests added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 19, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
8f74faa 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Tests added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jan 21, 2021
@Ezio-Sarthak
core: User's last activity status modified to be more user-friendly.
0a882d5 
UI improvement in user info view:
* Currently a user's last activity is represented by a datetime object.
  A function is added that returns a user's last activity in words,
  e.g, '1 hour ago', '3 days ago'.
* All timestamps before 2 weeks are viewed as 'more than 2 weeks ago'.

The above two points ensure equivalence with webapp.

Tests added (user presence status).

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 9, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
2916966 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 12, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
9ab696c 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 14, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
d552f2e 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 14, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
ad1aaa3 
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 16, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
80ce058 
Tests added.

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 18, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
2e7b907 
Tests added.

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 20, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
d8d5092 
Tests added.

Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 27, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
99f9daf 
With this commit, ZT would support keypress events for `i` in all
three views.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 31, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
ffeb56d 
With this commit, ZT would support keypress events for `i` in all
three views.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 3, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
8cf202c 
With this commit, ZT would support keypress events for `i` in all
three views.

Tests added.
Fixes zulip#511.
@neiljp neiljp added missing feature: user A missing feature for all users, present in another Zulip client and removed enhancement New feature or request labels Apr 5, 2021
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 8, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
c778944 
With this commit, ZT would support keypress events for `i` in all
three views.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 17, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
e2baea7 
With this commit, ZT would support keypress events for `i` in all
three views.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 27, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
37dd4b5 
With this commit, ZT would support keypress events for `i` in all
three views.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 27, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
0b68555 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 28, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
e0ee338 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 28, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
c39a7b2 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue May 13, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
21319e8 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 13, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
a9dc63f 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 6, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
b43fc1e 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 9, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
6da0b68 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 9, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
6dab928 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
neiljp pushed a commit to neiljp/zulip-terminal that referenced this issue Jul 10, 2021
@Ezio-Sarthak @neiljp
buttons: Add keypress events to trigger user info popup.
3dd0194 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 10, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
2c7bf46 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 10, 2021
@Ezio-Sarthak
buttons: Add keypress events to trigger user info popup.
5a039dd 
This commit wraps up the feature PR by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
neiljp pushed a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 10, 2021
@Ezio-Sarthak @neiljp
buttons: Add USER_INFO keypress events to trigger user info popup.
92dbb8c 
This commit wraps up the user-info feature by defining keypress
events to toggle user info view.

Tests added.
Fixes zulip#511.
neiljp pushed a commit that referenced this issue Jul 10, 2021
@Ezio-Sarthak @neiljp
buttons: Add USER_INFO keypress events to trigger user info popup.
05a468f 
This commit wraps up the user-info feature by defining keypress
events to toggle user info view.

Tests added.
Fixes #511.
@neiljp neiljp added this to the Next Release milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers missing feature: user A missing feature for all users, present in another Zulip client
Projects
None yet
Milestone
0.7.0
5 participants
@neiljp @zulipbot @sumanthvrao @SGeetansh @Ezio-Sarthak