Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List links at end of message (and/or in popup?) #618

Closed
neiljp opened this issue Apr 23, 2020 · 0 comments
Closed

List links at end of message (and/or in popup?) #618

neiljp opened this issue Apr 23, 2020 · 0 comments
Assignees
@preetmishra
Labels
area: message rendering enhancement New feature or request in progress

Comments

@neiljp
Copy link
Collaborator

neiljp commented Apr 23, 2020

There is already an existing older PR for listing the links in a message in a popup and handling them (and would benefit from being broken into smaller commits). Discussion in #zulip-terminal in the 'links' topic suggested the approach below as an alternative or additional route to take, and in any case extracting the links may be useful for both cases (check that discussion first in any case)

Currently links are shown pretty much as in raw markdown, which is workable but can be very verbose and disrupt the flow of a message, for such simple cases as the linkifiers, eg. This might be solved with #T1, but maybe not in chat.zulip.org expands to This might be solved with [#T1](https://github.com/zulip/zulip-terminal/pull/1), but maybe not, which disrupts the flow in the middle of the sentence.

One idea to improve the rendering has been to use a more 'reference list' or 'footnote' based approach, so the above sentence might render as:

This might be solved with #T1 [1], but maybe not
1 : https://github.com/zulip/zulip-terminal/pull/1

where the #T1, [1] and second line has different styling somehow to indicate they fit together (and without requiring a blank line)
@neiljp neiljp mentioned this issue Apr 23, 2020
Open
12 tasks
@preetmishra preetmishra self-assigned this Jun 25, 2020
@preetmishra preetmishra mentioned this issue Jun 26, 2020
Closed
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jun 28, 2020
@preetmishra
boxes: Add footlinks in MessageBox.
27741d7 
The footlinks are shown below the message content with a style that is
different from the rest of the message content but similar to msg_links.

Test added.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jun 28, 2020
@preetmishra
boxes: Add footlinks in MessageBox.
18492bf 
The footlinks are shown below the message content with a style that is
different from the rest of the message content but similar to msg_links.

Test added.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jul 8, 2020
@preetmishra
boxes: Add footlinks to improve message legibility in MessageBox.
0cc6499 
This indexes in-line message links and adds footlinks to avoid
disrupting the flow of [reading] a message.

Note: link_index and message_links are added as instance attributes to
track link indexes and to store link and its metadata respectively.

Test added and amended.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jul 9, 2020
@preetmishra
boxes: Add footlinks to improve message legibility in MessageBox.
e713379 
This indexes in-line message links and adds footlinks to avoid
disrupting the flow of [reading] a message.

Note: link_index and message_links are added as instance attributes to
track link indexes and to store link and its metadata respectively.

Test added and amended.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jul 12, 2020
@preetmishra
boxes: Add footlinks to improve message legibility in MessageBox.
8924cee 
This indexes in-line message links and adds footlinks to avoid
disrupting the flow of [reading] a message.

Note: link_index and message_links are added as instance attributes to
track link indexes and to store link and its metadata respectively.

Test added and amended.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jul 12, 2020
@preetmishra
boxes: Add footlinks to improve message legibility in MessageBox.
4a2bd0f 
This indexes in-line message links and adds footlinks to avoid
disrupting the flow of [reading] a message.

Note: link_index and message_links are added as instance attributes to
track link indexes and to store link and its metadata respectively.

Test added and amended.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jul 14, 2020
@preetmishra
boxes: Add footlinks to improve message legibility in MessageBox.
4118689 
This indexes in-line message links and adds footlinks to avoid
disrupting the flow of [reading] a message.

Note: message_links is added as an instance attribute to store links and
their metadata.

Test added and amended.

Fixes zulip#618.
preetmishra added a commit to preetmishra/zulip-terminal that referenced this issue Jul 15, 2020
@preetmishra
boxes: Add footlinks to improve message legibility in MessageBox.
f795fad 
This indexes in-line message links and adds footlinks to avoid
disrupting the flow of [reading] a message.

Additionally, message_links is added as an instance attribute to store
links and their metadata.

Test added and amended.

Fixes zulip#618.
@neiljp neiljp closed this as completed in 19909db Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preetmishra preetmishra

Labels
area: message rendering enhancement New feature or request in progress
Projects
None yet
Milestone
No milestone
3 participants
@neiljp @zulipbot @preetmishra