New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New markdown feature: Mention a time #691
Labels
area: message rendering
help wanted
This issue should be clear enough to work on
high priority
should be done as soon as possible
in progress
Milestone
Comments
neiljp
added
area: message rendering
help wanted
This issue should be clear enough to work on
high priority
should be done as soon as possible
labels
Jun 17, 2020
12 tasks
The markup has changed to |
preetmishra
added a commit
to preetmishra/zulip-terminal
that referenced
this issue
Aug 7, 2020
This adds support for rendering timezone-aware time mentions which were recently added to the Zulip's markdown suite. (See https://zulipchat.com/help/format-your-message-using-markdown#mention-a-time for markdown details.) Complimentary additions: * 'msg_time' style in themes.py. * 'TIME' symbol in symbols.py. Test amended. Fixes zulip#691.
preetmishra
added a commit
to preetmishra/zulip-terminal
that referenced
this issue
Aug 10, 2020
This adds support for rendering timezone-aware time mentions which were recently added to the Zulip's markdown suite. (See https://zulipchat.com/help/format-your-message-using-markdown#mention-a-time for markdown details.) Complimentary additions: * 'msg_time' style in themes.py. * 'TIME_MENTION_MARKER' symbol in symbols.py. Test amended. Fixes zulip#691.
preetmishra
added a commit
to preetmishra/zulip-terminal
that referenced
this issue
Aug 11, 2020
This adds support for rendering timezone-aware time mentions which were recently added to the Zulip's markdown suite. (See https://zulipchat.com/help/format-your-message-using-markdown#mention-a-time for markdown details.) Complimentary additions: * 'msg_time' style in themes.py. * 'TIME_MENTION_MARKER' symbol in symbols.py. Test amended. Fixes zulip#691.
preetmishra
added a commit
to preetmishra/zulip-terminal
that referenced
this issue
Aug 11, 2020
This adds support for rendering timezone-aware time mentions which were recently added to the Zulip's markdown suite. See https://zulipchat.com/help/format-your-message-using-markdown#mention-a-time for markdown details. Complimentary additions: * msg_time style in themes.py. * TIME_MENTION_MARKER symbol in symbols.py. Test amended. Fixes zulip#691.
preetmishra
added a commit
to preetmishra/zulip-terminal
that referenced
this issue
Aug 11, 2020
This adds support for rendering timezone-aware time mentions which were recently added to the Zulip's markdown suite. See https://zulipchat.com/help/format-your-message-using-markdown#mention-a-time for markdown details. Complimentary additions: * msg_time style in themes.py. * TIME_MENTION_MARKER symbol in symbols.py. Test amended. Fixes zulip#691.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: message rendering
help wanted
This issue should be clear enough to work on
high priority
should be done as soon as possible
in progress
We added a new markdown syntax,
!time(2020-06-18T17:32:00-07:00)
, that is meant to be a timezone-aware time displayed to all clients in local time (using the same mechanisms used in the timestamps in Zulip messages).There's likely some discussion that will happen on how these should be rendered; my current leaning is that we should put a clock icon/emoji at the start of the pills. But what's important for now is the core logic to make this feature work at all. In the webapp, it's this part of
rendered_markdown.js
:Implementing this should be a priority, since the whole point is that the time gets rendered properly :).
The text was updated successfully, but these errors were encountered: