Deal with no topic messages #754
Labels
enhancement
New feature or request
Milestone
Comments
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Jul 31, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 4, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 4, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 4, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 4, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 4, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 5, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Also, while editing such topics, the topic name would be shown as empty to the user, even though in reality it is not. This is done to make it easier for users to set names to empty topics, as well as to follow the behaviour of other clients. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 5, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Tests amended. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 7, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Test added. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 7, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Test added. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 7, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Test added. Fixes zulip#754.
kaustubh-nair
added a commit
to kaustubh-nair/zulip-terminal
that referenced
this issue
Aug 8, 2020
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Test added. Fixes zulip#754.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We don't allow sending of messages with an empty topic, however the web-app allows this by adding the messages to a topic named
(no topic). We should simulate something similar for ZT and care must be taken that this is consistent with what the web-app does.The text was updated successfully, but these errors were encountered: