Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a threshold configuration for footlinks #773

Closed
preetmishra opened this issue Aug 13, 2020 · 9 comments
Closed

Allow a threshold configuration for footlinks #773

preetmishra opened this issue Aug 13, 2020 · 9 comments
Labels
area: config enhancement New feature or request good first issue Good for newcomers PR needs review PR requires feedback to proceed
Milestone
0.7.0

Comments

@preetmishra
Copy link
Member

Currently, the footlinks can either be configured to enabled or disabled via the zuliprc.

However, we could potentially extend it to establish a middle-ground where only a certain number (threshold) of footlinks appear in the MessageBox.

Conversation link: https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Configurable.20footlinks.20by.20threshold.
@preetmishra preetmishra added enhancement New feature or request good first issue Good for newcomers labels Aug 13, 2020
@shanukun
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @shanukun! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@shanukun shanukun mentioned this issue Aug 19, 2020
Closed
shanukun added a commit to shanukun/zulip-terminal that referenced this issue Aug 20, 2020
@shanukun
footlinks: Add threshold configuration for footlinks.
c3eeec4 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc.

Fixes zulip#773.
shanukun added a commit to shanukun/zulip-terminal that referenced this issue Aug 20, 2020
@shanukun
footlinks: Add threshold configuration for footlinks.
002bbee 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc.

Fixes zulip#773.
shanukun added a commit to shanukun/zulip-terminal that referenced this issue Aug 21, 2020
@shanukun
footlinks: Add threshold configuration for footlinks.
e786e54 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc.

Fixes zulip#773.
@zulipbot
Copy link
Member

zulipbot commented Sep 8, 2020 •
edited

Hello @shanukun, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@Abhirup-99
Copy link
Contributor

@zulipbot claim

@neiljp
Copy link
Collaborator

neiljp commented Dec 4, 2020

@Abhirup-99 zulipbot is maybe not working right now, but note that someone else was working on a PR for this previously.

@shanukun Could you comment as to whether you plan to continue with that PR, or if someone else can pick up where you left off?

@Abhirup-99
Copy link
Contributor

@Abhirup-99 zulipbot is maybe not working right now, but note that someone else was working on a PR for this previously.

@shanukun Could you comment as to whether you plan to continue with that PR, or if someone else can pick up where you left off?

Ok, I would wait for his reply before starting then. Thanks for the reply.

@shanukun
Copy link
Collaborator

shanukun commented Dec 4, 2020

@neiljp Sorry for the late reply. I should've informed earlier.
@Abhirup-99 I am little busy with some work. You can definitely work on this.

Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Dec 5, 2020
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
a38e3fa 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc, retiring the previous
footlinks. Tests have been updated to reflect the change.
Fixes zulip#773.
@Abhirup-99 Abhirup-99 mentioned this issue Dec 5, 2020
Closed
@Abhirup-99
Copy link
Contributor

Abhirup-99 commented Dec 5, 2020 •
edited

@neiljp @preetmishra I have pushed a pr for this issue. Can you review it?

Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Dec 9, 2020
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
9ff5ab2 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc, retiring the previous
footlinks. Tests have been updated to reflect the change.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Dec 17, 2020
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
298922e 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc, retiring the previous
footlinks. Tests have been updated to reflect the change.
Fixes zulip#773.
@Abhirup-99
Copy link
Contributor

@zulipbot add "PR needs review"

@zulipbot zulipbot added the PR needs review PR requires feedback to proceed label Dec 19, 2020
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 10, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
c9eb86f 
This enables user to configure footlinks threshold settings
using footlinks_threshold in zuliprc, retiring the previous
footlinks. Tests have been updated to reflect the change.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 13, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
2722e0a 
This enables the user to configure the maximum footlinks
in zuliprc. The pr is backward compatible with footlinks
introduced in 0.5.2.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 13, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
26d90df 
This enables the user to configure the maximum footlinks
in zuliprc. The pr is backward compatible with footlinks
introduced in 0.5.2.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 14, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
608bb1e 
This enables the user to configure the maximum footlinks
in zuliprc. The pr is backward compatible with footlinks
introduced in 0.5.2.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 14, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
35aa5b5 
This enables the user to configure the maximum footlinks
in zuliprc. The pr is backward compatible with footlinks
introduced in 0.5.2.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 14, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
1cfdf1c 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 14, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
9281799 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 14, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
77841d6 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 17, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
8ae61f0 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 20, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
b65bfb2 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 20, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
495f20c 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 20, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
e16e1f1 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 28, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
b7cd789 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 28, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
9e8e23a 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 31, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
9e3fcea 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 31, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
94b57ec 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Feb 1, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
6e8f299 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Feb 1, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
50c9e8e 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Feb 1, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
35bb784 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Feb 1, 2021
@Abhirup-99
footlinks: Add threshold configuration for footlinks.
ec69179 
This enables the user to configure the maximum footlinks
in zuliprc. The change is backward compatible with
footlinks introduced in 0.5.2.README updated.
Fixes zulip#773.
@neiljp neiljp added this to the Next Release milestone Feb 2, 2021
@neiljp neiljp closed this as completed in 0eeb6ea Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: config enhancement New feature or request good first issue Good for newcomers PR needs review PR requires feedback to proceed
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

footlinks: Add threshold configuration for footlinks. Abhirup-99/zulip-terminal
5 participants
@neiljp @zulipbot @shanukun @preetmishra @Abhirup-99