Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a variety of footer notification styling #782

Closed
neiljp opened this issue Aug 20, 2020 · 1 comment · Fixed by #971
Closed

Support a variety of footer notification styling #782

neiljp opened this issue Aug 20, 2020 · 1 comment · Fixed by #971
Labels
area: UI General user interface update enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org
Milestone
0.7.0

Comments

@neiljp
Copy link
Collaborator

neiljp commented Aug 20, 2020

We can consider styling of footer notifications, eg. to distinguish errors/warnings from simple notifications like #781, and we could even add a positive one for "message sent" type notifications.
@neiljp neiljp added enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org labels Aug 20, 2020
@preetmishra preetmishra mentioned this issue Aug 30, 2020
Open
@Ezio-Sarthak
Copy link
Member

I presume no one's working on this currently. Since I am familiar with that part of the codebase, I would love to work on this issue!

@Ezio-Sarthak Ezio-Sarthak mentioned this issue Dec 29, 2020
Closed
2 tasks
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 25, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
431cf72 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "area:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
@Ezio-Sarthak Ezio-Sarthak mentioned this issue Mar 30, 2021
Merged
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 30, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
251cf02 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "area:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Mar 31, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
4a9431e 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "area:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 3, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
51ba272 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "area:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 10, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
c3240b8 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "footer:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 17, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
9c48738 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "footer:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 27, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
ad7a80c 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "footer:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 28, 2021
@Ezio-Sarthak
refactor: ui: Add semantic styles in set_footer_text().
8da6281 
This commit adds:
 * styling via a semantic parameter to the footer text in
   set_footer_text(). (default styling: "footer:neutral")
 * hooks to use to these semantic styles wherever reasonable.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 15, 2021
@Ezio-Sarthak
refactor: boxes/buttons/helper/model/ui: Hook semantic style helpers.
257760c 
Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
@Ezio-Sarthak
refactor: boxes/buttons/helper/model/ui: Hook semantic style helpers.
97fd43d 
Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
@Ezio-Sarthak
refactor: boxes/buttons/helper/model/ui: Hook semantic style helpers.
9a34ecd 
Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
@Ezio-Sarthak
refactor: boxes/buttons/helper/model/ui: Hook semantic style helpers.
a8ed8a9 
This commit replaces those instances of `set_footer_text` with new
helpers, that notify user of a success/error/warning response.

Tests amended.
Fixes zulip#782.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
@Ezio-Sarthak
refactor: boxes/buttons/helper/model/ui: Hook semantic style helpers.
4dd1121 
This commit replaces those instances of `set_footer_text` with new
helpers, that notify user of a success/error/warning response.

Tests amended.
Fixes zulip#782.
neiljp pushed a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
@Ezio-Sarthak @neiljp
boxes/buttons/core/helper/model/ui: Use new semantic report_* methods.
5eecc12 
This commit replaces those instances of `set_footer_text` with the new
report_* helpers, that notify user of a success/error/warning response.

Tests amended.

Fixes zulip#782.
neiljp pushed a commit that referenced this issue Jun 16, 2021
@Ezio-Sarthak @neiljp
boxes/buttons/core/helper/model/ui: Use new semantic report_* methods.
9eaa6b0 
This commit replaces those instances of `set_footer_text` with the new
report_* helpers, that notify user of a success/error/warning response.

Tests amended.

Fixes #782.
@neiljp neiljp added this to the Next Release milestone Jun 16, 2021
@neiljp neiljp added the area: UI General user interface update label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: UI General user interface update enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Add basic fields in footer notification styling Ezio-Sarthak/zulip-terminal
2 participants
@neiljp @Ezio-Sarthak