Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message editing: Add support for renaming of "(no topic)" messages #837

Closed
neiljp opened this issue Nov 22, 2020 · 3 comments · Fixed by #946
Closed

Message editing: Add support for renaming of "(no topic)" messages #837

neiljp opened this issue Nov 22, 2020 · 3 comments · Fixed by #946
Labels
area: message editing missing feature: user A missing feature for all users, present in another Zulip client
Milestone

Comments

@neiljp
Copy link
Collaborator

neiljp commented Nov 22, 2020

We currently support editing message topics of one or many messages, but only via one's own messages in those topics.

If a topic is "topicless", ie. shown as "(no topic)", then depending on server settings it should be possible to edit it independently of contribution to the topic:
https://zulip.com/help/configure-message-editing-and-deletion

@Ezio-Sarthak
Copy link
Member

I'd love to work on this issue!

@zee-bit
Copy link
Member

zee-bit commented Mar 10, 2021

@Ezio-Sarthak are you still working on this or can I take this up?

@Ezio-Sarthak
Copy link
Member

@zee-bit Sure, you can take it up 👍

zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 12, 2021
This commit add support for editing messages with no topic,
depending on the server setting "realm_allow_message_editing".

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 12, 2021
This commit add support for editing messages with no topic,
depending on the server setting "realm_allow_message_editing".

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 29, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled.
Any user can now edit the topic of a topicless message i.e. shown as
"(no topic)". This should bring message-editing functionality more
closer to the universal setting followed by other zulip clients.

Tests amended.
Fixes zulip#837.
@neiljp neiljp added the missing feature: user A missing feature for all users, present in another Zulip client label Apr 5, 2021
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Apr 28, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled.
Any user can now edit the topic of a topicless message i.e. shown as
"(no topic)". This should bring message-editing functionality more
closer to the universal setting followed by other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue May 20, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled.
Any user can now edit the topic of a topicless message i.e. shown as
"(no topic)". This should bring message-editing functionality more
closer to the universal setting followed by other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue May 21, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled.
Any user can now edit the topic of a topicless message i.e. shown as
"(no topic)". This should bring message-editing functionality more
closer to the universal setting followed by other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue May 22, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled.
Any user can now edit the topic of a topicless message i.e. shown as
"(no topic)". This should bring message-editing functionality more
closer to the universal setting followed by other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 2, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled.
Any user can now edit the topic of a topicless message i.e. shown as
"(no topic)". This should bring message-editing functionality more
closer to the universal setting followed by other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 4, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)"). This should bring message-editing functionality in ZT
more closer to the behaviour of other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 4, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)"). This should bring message-editing functionality in ZT
more closer to the behaviour of other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 4, 2021
This commit add support for editing messages with no topic,
depending on whether the server setting "realm_allow_message_editing"
is enabled or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)"). This should bring message-editing functionality in ZT
more closer to the behaviour of other zulip clients.

Tests amended.
Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 6, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 6, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 7, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 7, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 7, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 7, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 7, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Aug 1, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
neiljp pushed a commit to zee-bit/zulip-terminal that referenced this issue Aug 12, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes zulip#837.
neiljp pushed a commit that referenced this issue Aug 12, 2021
This commit adds support for editing messages with no topic, depending
on whether the server setting "realm_allow_message_editing" is enabled
or not.

Any user can now edit the topic of a topicless message (shown as
"(no topic)") in ZT. This should bring message-editing functionality in
ZT more closer to the behaviour of other zulip clients and the webapp in
general.

Tests amended.

Fixes #837.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message editing missing feature: user A missing feature for all users, present in another Zulip client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants