Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sender/recipient presence status in messages #896

Closed
neiljp opened this issue Jan 28, 2021 · 4 comments · Fixed by #987
Closed

Show sender/recipient presence status in messages #896

neiljp opened this issue Jan 28, 2021 · 4 comments · Fixed by #987
Labels
area: UI General user interface update enhancement New feature or request
Milestone

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jan 28, 2021

This is to clarify the intent behind PR #501, which isn't quite #406 (related to highlighting particular users eg. yourself vs others by name), but more to translate the presence information into an extra field in messages to avoid scanning through the user list to see the sender's active status. We could also apply this to recipients in PMs.

@neiljp neiljp added enhancement New feature or request area: UI General user interface update labels Jan 28, 2021
@neiljp
Copy link
Collaborator Author

neiljp commented Jan 28, 2021

The server has some aspect of this (eg. in list of PMs) and is considering more, starting with perhaps zulip/zulip#17137, zulip/zulip#17138 and PR zulip/zulip#17149.

More discussion here:
https://chat.zulip.org/#narrow/stream/137-feedback/topic/Status.20Evidence

@Ezio-Sarthak
Copy link
Member

@neiljp Thanks for opening the corresponding issue separately!

Would love to work on it!

@mkp6781
Copy link
Contributor

mkp6781 commented Apr 1, 2021

@Ezio-Sarthak Can I take this up if you have not started working on this?

@Ezio-Sarthak
Copy link
Member

@mkp6781 I just thought of pushing a PR for this a while ago, before I got occupied with other issues. I (vaguely) remember I have a remote branch for this, and looking forward to revive and push the work ASAP 😅. Thanks for querying 👍. I hope I'm able to clarify 😅

Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 7, 2021
This commit adds a status marker right after the sender's name in a
message content header. The users' dict from model is used to get
status of the sender. The default status of sender is kept `inactive`.

NOTE: Currently,

 * the status markers don't get updated regularly (only specific
   updates for events `handle_update_message_event`), and
 * 'all' the message headers (markers) don't get updated,

which would need implementing their handling in separate commits.
(potentially amending `start_presence_updates`)

Tests amended.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 7, 2021
This small commit adds presence renderer function introduced in
previous commit to the handler `start_presence_updates`. This way,
the method `update_msg_box_presence_markers` is called every minute.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 7, 2021
This small commit adds presence renderer function introduced in
previous commit to the handler `start_presence_updates`. This way,
the method `update_msg_box_presence_markers` is called every minute.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 8, 2021
This small commit adds presence renderer function introduced in
previous commit to the handler `start_presence_updates`. This way,
the method `update_msg_box_presence_markers` is called every minute.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 10, 2021
This small commit adds presence renderer function introduced in
previous commit to the handler `start_presence_updates`. This way,
the method `update_msg_box_presence_markers` is called every minute.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 17, 2021
This small commit adds presence renderer function introduced in
previous commit to the handler `start_presence_updates`. This way,
the method `update_msg_box_presence_markers` is called every minute.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 19, 2021
This commit:
 * introduces asynch method `update_msg_box_presence_markers` in middle
   column view class. It would be responsible for rendering the status
   icons (if present) in message boxes.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_box_presence_markers` is called every
   minute.

The function `update_msg_box_presence_markers` uses existing model method
`_update_rendered_view` to update the message box (if required).

Tests added and amended.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 19, 2021
This commit:
 * introduces asynch method `update_msg_box_presence_markers` in middle
   column view class. It would be responsible for rendering the status
   icons (if present) in message boxes.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_box_presence_markers` is called every
   minute.

The function `update_msg_box_presence_markers` uses existing model method
`_update_rendered_view` to update the message box (if required).

Tests added and amended.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 27, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Apr 28, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue May 29, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 16, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 22, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 25, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox class method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jun 26, 2021
This commit:
 * introduces a method `update_msg_list_presence_markers` in middle column
   view class. It would be responsible for rendering the status markers
   (if present) in message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_msg_list_presence_markers` is called every
   minute.

The helper `update_msg_list_presence_markers` uses MessageBox method
`update_msg_content_header` (added in previous commit) to update a message
box (if required).

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 4, 2021
This commit:
 * introduces a method `update_message_list_status_markers` in middle
   column view class. It would be responsible for rendering the status
   markers (if required) in the message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_message_list_status_markers` is called
   every minute.

The helper `update_message_list_status_markers` uses MessageBox method
`update_message_author_status` (added in previous commit) to update
message boxes if author field is present.

Fixes zulip#896.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 4, 2021
This commit:
 * introduces a method `update_message_list_status_markers` in middle
   column view class. It would be responsible for rendering the status
   markers (if required) in the message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_message_list_status_markers` is called
   every minute.

The helper `update_message_list_status_markers` uses MessageBox method
`update_message_author_status` (added in previous commit) to update
message boxes if author field is present.

Fixes zulip#896.
neiljp pushed a commit that referenced this issue Jul 4, 2021
This commit:
 * introduces a method `update_message_list_status_markers` in middle
   column view class. It would be responsible for rendering the status
   markers (if required) in the message list.
 * adds presence renderer function to the handler `start_presence_updates`.
   This way, the method `update_message_list_status_markers` is called
   every minute.

The helper `update_message_list_status_markers` uses MessageBox method
`update_message_author_status` (added in previous commit) to update
message boxes if author field is present.

Fixes #896.
@neiljp neiljp added this to the Next Release milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants