Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from type comments to inline type annotations #901

Closed
neiljp opened this issue Jan 30, 2021 · 5 comments · Fixed by #910
Closed

Move from type comments to inline type annotations #901

neiljp opened this issue Jan 30, 2021 · 5 comments · Fixed by #910
Assignees
@ahmedabuamra
Labels
area: refactoring in progress
Milestone
0.7.0

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jan 30, 2021

This breaks out the last part of #838, which is enabled by the move to python 3.6+.

This could be automated using com2ann, though note that tool requires python 3.8+.
@zulipbot
Copy link
Member

Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!

@neiljp
Copy link
Collaborator Author

neiljp commented Jan 30, 2021

^ This seems like a bug in zulipbot label-checking?

@neiljp neiljp mentioned this issue Jan 30, 2021
Merged
5 tasks
@ahmedabuamra
Copy link
Contributor

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 5, 2021

Hello @ahmedabuamra!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@ahmedabuamra ahmedabuamra mentioned this issue Feb 5, 2021
Merged
ahmedabuamra added a commit to ahmedabuamra/zulip-terminal that referenced this issue Feb 6, 2021
@ahmedabuamra
refactor: Move from type comments to inline type annotations.
9730596 
Ran `com2ann` in the project folder to auto re-write the files.

Fixes: zulip#901
ahmedabuamra added a commit to ahmedabuamra/zulip-terminal that referenced this issue Feb 6, 2021
@ahmedabuamra
refactor: Move from type comments to inline type annotations.
50641de 
Ran `com2ann` in the project folder to auto re-write the files.

Fixes: zulip#901
@ahmedabuamra
Copy link
Contributor

I'm sorry for working on this issue without assignment.
I wanted to try com2ann and save you some time. Thanks.

ahmedabuamra added a commit to ahmedabuamra/zulip-terminal that referenced this issue Feb 6, 2021
@ahmedabuamra
refactor: Move from type comments to inline type annotations.
3289791 
Ran `com2ann` in the project folder to auto re-write the files.

Note:
* tools/lister.py and zulipterminal/config/keys's KEY_BINDINGS
variable still use comments typing

Fixes: zulip#901
ahmedabuamra added a commit to ahmedabuamra/zulip-terminal that referenced this issue Feb 6, 2021
@ahmedabuamra
refactor: Move from type comments to inline type annotations.
78148ee 
Ran `com2ann` in the project folder to auto re-write the files.

Note:
* tools/lister.py file and OrderedDict variabled still use comments typing

Fixes: zulip#901
ahmedabuamra added a commit to ahmedabuamra/zulip-terminal that referenced this issue Feb 6, 2021
@ahmedabuamra
refactor: Move from type comments to inline type annotations.
819cb39 
Ran `com2ann` in the project folder to auto re-write the files.

Note:
* tools/lister.py file has not been modified as imported from zulip/zulip

Fixes: zulip#901
ahmedabuamra added a commit to ahmedabuamra/zulip-terminal that referenced this issue Feb 6, 2021
@ahmedabuamra
refactor: Move from type comments to inline type annotations.
efd4d0b 
Ran `com2ann` in the project folder to auto re-write the files.

Note:
* tools/lister.py file has not been modified as imported from zulip/zulip

Fixes: zulip#901
@neiljp neiljp added this to the Next Release milestone Feb 7, 2021
neiljp pushed a commit that referenced this issue Feb 7, 2021
@ahmedabuamra @neiljp
refactor: Move from type comments to inline type annotations.
54c9737 
Ran `com2ann` in the project folder to auto re-write the files.

Note:
* tools/lister.py file has not been modified as imported from zulip/zulip

Fixes: #901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmedabuamra ahmedabuamra

Labels
area: refactoring in progress
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

refactor: Move from type comments to inline type annotations. ahmedabuamra/zulip-terminal
3 participants
@neiljp @zulipbot @ahmedabuamra