Autocomplete mention with spaces between first and last names #925
Labels
area: autocomplete
bug
Something isn't working
missing feature: user
A missing feature for all users, present in another Zulip client
Milestone
Comments
|
Can anyone help me out how this could be resolved? |
|
Hii, any updates or tips on this? |
|
@avats-dev Apologies for the slow reply. I'm wary you've understood the issue correctly? I think the issue description might need some improvements, as the autocomplete doesn't seem to show any results for full names? Hop in anytime in #zulip-terminal stream on czo. Feel free to discuss any issue/bug/problems etc in the community :) |
|
@avats-dev Are you asking as a user or a potential contributor? The solution may involve dynamically updating the delimiter which urwid-readline provides, but that's just an idea based on the approach I took to resolve this with autocomplete with spaces in the stream header, which is a lot simpler than general autocomplete in a body of text. |
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Apr 22, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces. This is a potential WIP commit, and would possibly be amended as per the feedback. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Apr 27, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. This is a potential WIP commit, and would possibly be amended as per the feedback. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Apr 29, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. This is a potential WIP commit, and would possibly be amended as per the feedback. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 17, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. This is a potential WIP commit, and would possibly be amended as per the feedback. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 17, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. This is a potential WIP commit, and would possibly be amended as per the feedback. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 21, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. This is a potential WIP commit, and would possibly be amended as per the feedback. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
neiljp
added
the
missing feature: user
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 25, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. The default completer delims for message compose are stored in the constant `DELIMS_MESSAGE_COMPOSE`. The commit also fixes a bug in which a user isn't able to use autocompletes for space-containing texts. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 26, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. The default completer delims for message compose are stored in the constant `DELIMS_MESSAGE_COMPOSE`. The commit also fixes a bug in which a user isn't able to use autocompletes for space-containing texts. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 30, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. The default completer delims for message compose are stored in the constant `DELIMS_MESSAGE_COMPOSE`. The commit also fixes a bug in which a user isn't able to use autocompletes for space-containing texts. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
Ezio-Sarthak
added a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 30, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. The default completer delims for message compose are stored in the constant `DELIMS_MESSAGE_COMPOSE`. The commit also fixes a bug in which a user isn't able to use autocompletes for space-containing texts. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
neiljp
pushed a commit
to Ezio-Sarthak/zulip-terminal
that referenced
this issue
Jul 31, 2021
This small commit explicitly sets delimiter for msg_write_box, in order to support autocompletion of text with whitespaces, for both private and stream write boxes. Note that the delims specifed are default ones, except that whitespace is ignored, so as to make it function properly in autocompletes. The default completer delims for message compose are stored in the constant `DELIMS_MESSAGE_COMPOSE`. The commit also fixes a bug in which a user isn't able to use autocompletes for space-containing texts. Tests amended (comments) and added. The existing tests for space-containing prefixes are justified with this commit. Fixes zulip#925 as a side effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mentioning a user with first name OR last name only works fine, but when trying to autocomplete mentioning them with full name, the autocomplete suggest users based on the last name only (assuming putting the cursor at the end of the last name) while it should use the words before the last name in suggestions too.
The text was updated successfully, but these errors were encountered: