Blacken/lint rest of tools/ #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Note that this *only* applies flake8 and black to 3 files matching *.py so far.
* lint-all * unicode fetch/convert scripts * font-styles-test
Main exclusions are files written in shell script.
neiljp
force-pushed
the
2021-07-20-blacken-all-tools
branch
from
1b87dd4
to
1270f14
Compare
This does not affect explicit calls with tools/, but does avoid accidentally applying flake8 to a nested virtual environment containing many source files (currently 62 vs 2008).
|
Just pushed a minimal update here to be compatible with the run-mypy change related to the typing work from @prah23 and apply some commit text polish. Will merge very soon. |
neiljp
force-pushed
the
2021-07-20-blacken-all-tools
branch
from
1270f14
to
62c681c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up to #1087, which did not fully achieve its aim since python scripts without a
.pyending were not identified.Other scripts are now updated to be covered, with an additional script providing a list of tools in python, given certain known exclusions. This script is used as a module in
tools/lint-all, and separately in CI to explicitly include those files.A broader approach is likely possible with zulint or using lister.py in future, but having these files covered and tested, and not accidentally losing compliance is the intent here.
Tested?