Support upper-case theme color spec & Clarify 16-color names #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for urwid generally refers to lower case as the valid format, but it lowers the barrier to entry for theme authors if we allow upper case and explicitly convert ourselves. Note added to THEME_CONTRIBUTING.md Tests updated.
Our color specification uses underscores to enable styling within a single string and make it simpler to separate color variations (eg. "light gray") within a longer space-separated string. Tests simplified to check directly against versions with underscores.
neiljp
added
area: documentation
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The documentation for urwid generally refers to lower case as the valid
format, but it lowers the barrier to entry for theme authors if we allow
upper case and explicitly convert ourselves.
For 16 color names, our color specification uses underscores to enable styling within a
single string (more generally) and make it simpler to separate color variations (eg.
"light gray") within a longer space-separated string.
Tested?