bugfix: model: Avoid creating empty messages from reaction events. #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates an approach taken in the original reaction implementation. Since locally cached messages are currently stored in a `defaultdict`, direct indexing with a non-present message-id creates an empty message. Such messages then generate `KeyError`s when flags are updated later (eg. marking read, toggling star status), if the message has not been fetched. Tests updated to explicitly exclude generation of empty index for reaction events. Fixes zulip#920.
neiljp
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates an approach taken in the original reaction implementation.
Since locally cached messages are currently stored in a
defaultdict,direct indexing with a non-present message-id creates an empty message.
Such messages then generate
KeyErrors when flags are updated later(eg. marking read, toggling star status), if the message has not been
fetched.
Tests updated to explicitly exclude generation of empty index for
reaction events.
Fixes #920.
Tested?
Notes & Questions
This suggests we should move away from
defaultdictfor at least this data structure, as access masks generation of invalid data.Interactions
This is purely a bugfix. This prompts thoughts on further refactoring, but an outstanding branch for improving reaction handling may conflict with that, so this is left for now.