Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PM typing notification settings #1163

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Mar 12, 2022

What does this PR do?

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • Introduce & test new centralized user settings in model for new property (from register)
  • Update the new property from events
  • Use the updating property to determine whether to send typing events

Notes & Questions

This introduces user settings, which is intended as a new central location for this. This new setting is set and updated via user_settings, whereas older settings may be in multiple locations dependent on parameter passed to the server (user_settings_object)

I have initially assumed that this setting is only available in the new structure, but that's not completely clear to me.

Visual changes

For servers which support this setting, ZT currently shows warning notices in the footer, returned from the server. If requested via the setting, this PR avoids sending notifications, so the server doesn't send a notice, which then isn't shown.

@zulipbot zulipbot added size: XL [Automatic label added by zulipbot] api migrations labels Mar 12, 2022
@neiljp neiljp added area: event handling How events from the server are responded to missing feature: user A missing feature for all users, present in another Zulip client labels Mar 14, 2022
@neiljp
Copy link
Collaborator Author

neiljp commented Mar 14, 2022

Merging this now after discussion in #api design > typing notification endpoint.

@neiljp neiljp merged commit 62d2e75 into zulip:main Mar 14, 2022
@neiljp neiljp added this to the Next Release milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api migrations area: event handling How events from the server are responded to missing feature: user A missing feature for all users, present in another Zulip client size: XL [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants