Respect PM typing notification settings #1163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tested?
Commit flow
Notes & Questions
This introduces user settings, which is intended as a new central location for this. This new setting is set and updated via
user_settings
, whereas older settings may be in multiple locations dependent on parameter passed to the server (user_settings_object
)I have initially assumed that this setting is only available in the new structure, but that's not completely clear to me.
Visual changes
For servers which support this setting, ZT currently shows warning notices in the footer, returned from the server. If requested via the setting, this PR avoids sending notifications, so the server doesn't send a notice, which then isn't shown.