Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize setting for hiding of PM content in notifications #1166

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Mar 15, 2022

What does this PR do?

This primarily fetches and dynamically updates a user setting which optionally hides private message content from appearing in notifications.

This requires fetching a new category of data (in older servers), as well as handling the update of that data.

This user setting is, along with the 24h/12h setting in a refactor, in the new user settings structure added recently.

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • Migrate 24h/12h setting into new structure (refactor)
  • Do initial fetch of new setting
  • Support updating of new setting
  • Use new setting to control display of content

Notes & Questions

Settings will eventually be initialized and updated differently as per #1108.

@neiljp neiljp added area: event handling How events from the server are responded to area: refactoring missing feature: user A missing feature for all users, present in another Zulip client labels Mar 15, 2022
@neiljp neiljp added this to the Next Release milestone Mar 15, 2022
@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Mar 15, 2022
@zulipbot
Copy link
Member

Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out!

@neiljp neiljp merged commit cb79fba into zulip:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: event handling How events from the server are responded to area: refactoring missing feature: user A missing feature for all users, present in another Zulip client size: L [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants