Use only colors from suggested gruvbox palettes #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rht
reviewed
Mar 24, 2022
Dishti-Oberai
approved these changes
Mar 26, 2022
neiljp
force-pushed
the
2022-03-22-gruvbox-tidying
branch
from
16f4dd4
to
53a6979
Compare
zulipbot
added
size: L
|
I've just made a preliminary equivalent set of changes for the light version. I'm incrementally rearranging the color ordering/grouping as this happens. There are still some overlapping colors which I'd like to avoid in both dark and light from these changes. |
According to the official gruvbox style, FADED_* colors should not appear in the dark mode, so this commit adjusts FADED to BRIGHT or NEUTRAL versions. Ref: https://github.com/morhetz/gruvbox#palette In order to improve contrast if it is a background change, the foreground is shifted from standard foreground (LIGHT2) to the inverse (background), ie. DARK0_HARD. To improve variation & avoid confusion, some more specific hues are used: - background NEUTRAL_BLUE is used for all selections (from FADED_BLUE) - background BRIGHT_BLUE is used for general narrows (from FADED_BLUE) - background BRIGHT_YELLOW is used for area:user (from FADED_BLUE) (saving BRIGHT_BLUE for area:stream) - background NEUTRAL_PURPLE is used for area:msg (from BRIGHT_RED) (saving BRIGHT_RED for area:error) - background NEUTRAL_PURPLE is used for task:warning (from BRIGHT_RED) (saving BRIGHT_RED for task:error) Colors reordered in colors_gruvbox.py accordingly.
According to the official gruvbox style, BRIGHT_* colors should not appear in the light mode, so this commit adjusts BRIGHT to FADED or NEUTRAL versions. Ref: https://github.com/morhetz/gruvbox#palette In order to improve contrast if it is a background change, the foreground is shifted from standard foreground (DARK2) to the inverse (background), ie. LIGHT0_HARD. To improve variation & avoid confusion, some more specific hues are used: - background NEUTRAL_BLUE is used for all selections (from BRIGHT_BLUE) - background FADED_BLUE is used for general narrows (from BRIGHT_BLUE) - background FADED_YELLOW is used for area:user (from BRIGHT_BLUE) (saving FADED_BLUE for area:stream) - background NEUTRAL_PURPLE is used for area:msg (from FADED_RED) (saving FADED_RED for area:error) - background NEUTRAL_PURPLE is used for task:warning (from FADED_RED) (saving FADED_RED for task:error) Colors reordered in colors_gruvbox.py accordingly.
neiljp
force-pushed
the
2022-03-22-gruvbox-tidying
branch
from
53a6979
to
84a1cc8
Compare
neiljp
changed the title
neiljp
force-pushed
the
2022-03-22-gruvbox-tidying
branch
from
84a1cc8
to
3be7509
Compare
|
This should be the final version to review now. Changes since the 2nd iteration are:
|
|
I find the changes good enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the light variant was added, we noticed that the gruvbox palettes have the faded/neutral/bright variants of colors, and it was suggested to group these.
It is noticeable in the palettes linked below that:
The existing dark variant uses some faded colors, and the light variant seems to use some bright ones. This PR is intended to address these issues, and group colors to make this usage clearer.
https://github.com/morhetz/gruvbox#palette
Tested?
Commit flow
Notes & Questions
The term 'mode' is used in the color palette comments, based on the gruvbox terminology.
Visual changes
Please do fetch this PR for comparison, as colors can look differently in local systems.
Main elements that changed: (as evident in the diff) <-- DARK MODE