Indicate web-public streams differently #1177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is intended to fix most of #712 (#1135)
See #zulip-terminal > Web public marker #T1135/#T712
Tested?
Commit flow
Notes & Questions
This needs some tests fixed and I'm planning an additional refactor, but pushing now to get feedback.
update Tests are now fixed and extended.
Visual changes
Currently, web-public streams are shown as
A
. This is not ideal, but I've not found a reliable symbol/character yet (W
in bold was very full/blocky). If you fetch the PR you can play with variations by changing the character insymbols.py
.update After debate on the stream, we currently have
⊚
as an approximation to a narrow (1-character-wide) circular symbol. We can explore this further when we explore symbol themes #938 (maybe #1114)