Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate web-public streams differently #1177

Merged
merged 7 commits into from
Apr 3, 2022

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Mar 23, 2022

What does this PR do?

This is intended to fix most of #712 (#1135)

See #zulip-terminal > Web public marker #T1135/#T712

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • Add model accessor for stream type, given stream id
  • Use new accessor outside of model (in UI)
  • Add fixtures for a web public stream & adjust existing tests
  • Add symbol and extend existing code minimally to indicate symbol in most cases
  • Add symbol rendering in stream list
  • Refactor duplicated if/elif blocks to use new common dict in ui_mappings (descriptions)
  • Refactor if/elif blocks to use same dict for icons too

Notes & Questions

This needs some tests fixed and I'm planning an additional refactor, but pushing now to get feedback.

update Tests are now fixed and extended.

Visual changes

Currently, web-public streams are shown as A. This is not ideal, but I've not found a reliable symbol/character yet (W in bold was very full/blocky). If you fetch the PR you can play with variations by changing the character in symbols.py.

update After debate on the stream, we currently have as an approximation to a narrow (1-character-wide) circular symbol. We can explore this further when we explore symbol themes #938 (maybe #1114)

@neiljp neiljp added area: UI General user interface update feedback wanted missing feature: user A missing feature for all users, present in another Zulip client labels Mar 23, 2022
@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Mar 23, 2022
@zulipbot zulipbot added size: XL [Automatic label added by zulipbot] and removed size: L [Automatic label added by zulipbot] labels Mar 30, 2022
@neiljp neiljp changed the title [WIP] Indicate web-public streams differently Indicate web-public streams differently Mar 30, 2022
@neiljp neiljp added this to the Next Release milestone Mar 30, 2022
@neiljp
Copy link
Collaborator Author

neiljp commented Apr 1, 2022

Merging this is temporarily blocked on reports that the selected symbol doesn't render in WSL, though does in Windows Terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update feedback wanted missing feature: user A missing feature for all users, present in another Zulip client size: XL [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants