Bugfix to update stream marker/color on editing stream message #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could previously be triggered if editing a stream message in a private stream.
We re-calculate the color and marker for a stream consistently in the new-stream-message or edit-stream-message setup methods, making this older code unnecessary. In principle this might be incorporated in the common method, but it is clearer in the individual methods due to differing usage.
neiljp
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If editing a message in a private stream (or soon, a web-public stream), the stream marker was not set correctly.
One commit adjusts this to do so correctly using the new helper method, while the other removes the duplicate code originally used prior to the helper method.
Tested?
Notes & Questions
We could add tests for the stream marker/color setting in various edit modes - we have none currently. The marker/color behavior is tested separately using a test for the common helper method.