Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add subscribe/unsubscribe feature. #1240

Closed
wants to merge 0 commits into from
Closed

[WIP] Add subscribe/unsubscribe feature. #1240

wants to merge 0 commits into from

Conversation

mounilKshah
Copy link
Collaborator

@mounilKshah mounilKshah commented Jun 28, 2022 •
edited
Loading

Moved to #1266

What does this PR do?
This PR is to add subscribe-unsubcribe toggle for all streams present in the stream.
Currently, the commit in the PR only works for a single stream.
Partial fix for #570

Discussion topic:
zulip-terminal>Add provision to subscribe to streams

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • Popup for subscribe/unsubscribe toggle

Notes & Questions

  • Works only for one stream and it has to be in the same session. Needs to be extended to all streams
  • Does not update the stream view, nor the messages in the MiddleColumn

Visual changes

  • To be added

@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Jun 28, 2022
@mounilKshah mounilKshah added the area: event handling How events from the server are responded to label Jun 28, 2022
@zulipbot zulipbot added size: XL [Automatic label added by zulipbot] and removed size: L [Automatic label added by zulipbot] labels Oct 15, 2022
@zulipbot zulipbot added size: XS [Automatic label added by zulipbot] and removed size: XL [Automatic label added by zulipbot] labels Oct 15, 2022
@mounilKshah mounilKshah mentioned this pull request Oct 15, 2022
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: event handling How events from the server are responded to size: XS [Automatic label added by zulipbot]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mounilKshah @zulipbot