Skip muted topics and streams on n key #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While functional in the MiddleColumnView, it only relies upon state stored there and only accessed by itself, as well as model data, so this migrates it into the model along with that state. This will make it easier to test the core functionality independently of the UI when we adjust the feature to depend upon other existing model state such as muted streams and topics. Also ensure the current behavior is maintained for now by explicitly sorting the unread topics keys, which previous relied upon the initial and subsequent data being ordered. Tests migrated, simplified and set to use valid stream+topic data.
Logic originally developed by Aman Agrawal (amanagr) in zulip#442. Updated to take into account: - already-added (slightly different) is_muted[stream|topic] methods - migration of get_next_unread_topic into model (simplifying tests) Also ensure the current behavior is maintained for now by explicitly sorting the unread counts, which previous relied upon the initial and subsequent data being ordered. Tests added. Co-authored by: Aman Agrawal <f2016561@pilani.bits-pilani.ac.in>
neiljp
force-pushed
the
2022-08-14-skip-muted-on-n
branch
from
718f3e7
to
70bf9d4
Compare
This was referenced Aug 16, 2022
This was referenced Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an adjusted version of the rebuild of #442 in #1239, so if merged will supersede both of those.
The motivation for this was upon considering the test adjustments which were absent in the draft updated PR (#1239), it seemed much more natural to migrate the appropriate function into the model itself. The main logic is therefore the same as #442, but the surrounding code is quite different, including tests.
I'm strongly considering merging this promptly, but I'd welcome a read-through, and testing by anyone who looked at #T1239.
This was discussed in #zulip-terminal > Skip muted topics and streams on 'n' #T442 #T1239
(may update topic name given this PR)
Tested?
Notes & Questions
This explicitly adds what I believe is the current behavior of ordering by stream id and then topic name. As indicated in #1239, there is likely a lot of scope for improvement beyond that, assuming we want to mimic web app use of this feature.