-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Improve autocomplete docs & expand PMs to Private Messages #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
370faf0
to
eec831a
Compare
Summarize specific uses of autocomplete and why it is helpful. Add note comparing autocomplete to stream/topic/user searches.
Using abbreviations can be confusing, particularly for new users, and is ideally avoided during most discussions and documentation. In addition, an abbreviated form is not used for stream-messages, so it is also clearer if both are written out in full. This does not update any similar abbreviations in the code, except in the docstring of buttons.py, which is used to autogenerate the developer-file-overview.md file. NOTE: This commit is in preparation for an intended upcoming change to use 'Direct Messages' for this naming in zulip#1288.
4 tasks
theViz343
added a commit
to theViz343/zulip-terminal
that referenced
this pull request
Mar 17, 2023
This commit replaces the use of 'private' with 'direct' in the docs. It also removes instances of PM (abbreviation for private message) following the change in zulip#1293. Fixed the large column width issue for developer-file-overview.md.
theViz343
added a commit
to theViz343/zulip-terminal
that referenced
this pull request
Mar 18, 2023
This commit replaces the use of 'private' with 'direct' in the docs. It also removes instances of PM (abbreviation for private message) following the change in zulip#1293.
neiljp
pushed a commit
to theViz343/zulip-terminal
that referenced
this pull request
Mar 21, 2023
This commit replaces the use of 'private' with 'direct' in the docs. It also removes instances of PM (abbreviation for private message) following the change in zulip#1293.
neiljp
pushed a commit
that referenced
this pull request
Mar 21, 2023
This commit replaces the use of 'private' with 'direct' in the docs. It also removes instances of PM (abbreviation for private message) following the change in #1293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: autocomplete
area: documentation
Requires changes in documentation
PR ready to be merged
PR has been reviewed & is ready to be merged
size: L
[Automatic label added by zulipbot]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Primarily:
Tested?