Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull_request_template: Update and improve PR template. #1357

Merged
merged 1 commit into from
Mar 27, 2023

Commits on Mar 26, 2023

  1. pull_request_template: Update and improve PR template.

    The main changes are:
    - Simplifying titles contributors see while editing via ### instead of bold
    - Adding 'and why' to the 'What does this PR do?' top title
    - Updating the 'Tested?' section to be 'How did you test this?'
      - Generally clarifying each entry
      - Manual checks split into behavioral and visual entries
      - 'Linting and tests per commit' removed in favor of a refactor-only entry
    - Adding a self-review checklist (for each commit) to emphasize expectations
    - Adding an 'External discussion & connections' section with checkboxes
      - The comments re including Fixes and chat link requests are here
      - The 'Interactions' section examples are also moved here
      - Other entries are added to prompt contributors (unmerged/followup PRs)
    - Adds tips to the Visual changes section
      - Zulip general tools
      - using asciinema for 'videos'
    neiljp committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    1df667b View commit details
    Browse the repository at this point in the history