Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of pressing Esc during message compose #1362

Closed
wants to merge 2 commits into from
Closed

Improve handling of pressing Esc during message compose #1362

wants to merge 2 commits into from

Commits on Mar 28, 2023

  1. core: Add exit_compose_confirmation_popup function. 

    This function facilitates showing a confirmation popup when esc key is
pressed when user is in the msg compose box.
    @srdeotarse
    srdeotarse committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    6da7795 View commit details
    Browse the repository at this point in the history

  2. boxes: Add condition of content length on msg compose to show popup. 

    Fixes zulip#1342
If length of text in msg compose box > 10, then only show confirmation
popup.
    @srdeotarse
    srdeotarse committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    db08c8d View commit details
    Browse the repository at this point in the history